Add stock media upload methods to media store #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/add-stock-media-methods-to-media-store
develric
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Hi @planarvoid , code LGTM. Tested this PR using the companion WPAndroid PR. I've documented with some more details a few issues I had in that companion PR comment, but this one LGTM.
Base automatically changed from
feature/introduce-cache-to-stock-media-store
to
develop
October 7, 2020 08:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of three PRs. It pulls the method to upload stock media from the MediaStore to the StockMediaStore and makes it a suspend function. As part of this change I've pulled some of the common logic into a utility class.
This PR can be tested by the related WPAndroid PR - wordpress-mobile/WordPress-Android#13009