[Gutenberg] media upload progress reattach #9129
Conversation
…o JS on reattachment
…to gb/media_upload_progress_reattach
… progress updates right when componentDidMount
| @@ -283,7 +301,7 @@ public void setTitle(CharSequence title) { | |||
| return; | |||
| } | |||
|
|
|||
| mWPAndroidGlueCode.setContent(title.toString(), null); | |||
| mWPAndroidGlueCode.setTitle(title.toString()); | |||
There was a problem hiding this comment.
Hmm not sure why this change is part of this PR?
| @@ -297,7 +315,7 @@ public void setContent(CharSequence text) { | |||
| } | |||
|
|
|||
| String postContent = removeVisualEditorProgressTag(text.toString()); | |||
| mWPAndroidGlueCode.setContent(null, postContent); | |||
There was a problem hiding this comment.
Also for this one, not sure why is changed here?
| @@ -58,6 +63,9 @@ | |||
|
|
|||
| private WPAndroidGlueCode mWPAndroidGlueCode; | |||
|
|
|||
| private ConcurrentHashMap<String, Float> mUploadingMediaProgressMax = new ConcurrentHashMap<>(); | |||
| private Set<String> mFailedMediaIds = new HashSet<>(); | |||
There was a problem hiding this comment.
Any reason to use interface Set instead of HashSet ?
There was a problem hiding this comment.
not really, just copied the code to represent the same functionality we had as parity with Aztec from here https://github.com/wordpress-mobile/WordPress-Android/blob/develop/libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/AztecEditorFragment.java#L172
| new OnReattachQueryListener() { | ||
| @Override | ||
| public void onQueryCurrentProgressForUploadingMedia() { | ||
| for (String mediaId : mUploadingMediaProgressMax.keySet()) { |
There was a problem hiding this comment.
Hey @mzorz, what about moving this into a separate method (e.g. updateMediaProgress or similar)
and also maybe we can put this mUploadingMediaProgressMax.get(mediaId) into variable (e.g. int currentProgress) before passing it to method ?
There was a problem hiding this comment.
agreed, addressed moving into a new method in 6cb4c90 - I think the intermediate local variable is unnecessary as it's only going to be used in 1 place; we can use that when it's referenced in more than 1 place so the .get() method doesn't get called on every reference. Does it make sense?
Description
This PR introduces upload progress reattachment so the progress updates are reflected on the UI when you exit and enter the Editor again.
Related PRs
To test:
Note:
@marecar3 the base branch corresponds to PR #9120, which also needs to be updated with latest
developto clear the commit history difference seen here.Update release notes:
RELEASE-NOTES.txt.