[Gutenberg] Remove Keyboard Aware Flatlist # #18082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | WordPress | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 753891a | |
|
|||||||||||
 |
💡 Scan this QR code with your Android phone to download and install the APK directly on it. | |
| App | Jetpack | |
| Build Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | 753891a | |
This was referenced Mar 10, 2023
geriux
force-pushed
the
gutenberg/remove-keyboard-aware-flatlist
branch
from
753891a to
52f3930
Compare
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18082-4e7234c | |
| Commit | 4e7234c | |
| Direct Download | jetpack-prototype-build-pr18082-4e7234c.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18082-4e7234c | |
| Commit | 4e7234c | |
| Direct Download | wordpress-prototype-build-pr18082-4e7234c.apk |
geriux
force-pushed
the
gutenberg/remove-keyboard-aware-flatlist
branch
from
52f3930 to
62a1806
Compare
geriux
force-pushed
the
gutenberg/remove-keyboard-aware-flatlist
branch
from
818be90 to
78e1b58
Compare
fluiddot
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Approved via WordPress/gutenberg#48791 (review).
NOTE: We might consider adding this change to the release notes as it's user-facing.
geriux
force-pushed
the
gutenberg/remove-keyboard-aware-flatlist
branch
from
342b63e to
4e7234c
Compare
Definitely! I've added it to the Gutenberg mobile PR, I'll make sure we update the main apps release notes on the next editor release 👍 |
|
Found 1 violations: The PR caused the following dependency changes: \--- project :libs:editor
- \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.93.0-alpha1
- +--- com.facebook.fresco:animated-gif:2.0.0
- | +--- com.parse.bolts:bolts-tasks:1.4.0
- | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.facebook.fresco:animated-base:2.0.0
- | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | +--- com.facebook.fresco:animated-drawable:2.0.0
- | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
- | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
- | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
- | \--- com.parse.bolts:bolts-tasks:1.4.0
- +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
- +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
- | +--- com.google.android.exoplayer:exoplayer:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
- | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | | \--- com.google.guava:guava:27.1-android
- | | | | +--- com.google.guava:failureaccess:1.0.1
- | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
- | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
- | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
- | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
- | | \--- androidx.media:media:1.2.1 (*)
- | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
- | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
- | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
- | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
- | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
- | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
- | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
- +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
- +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
- +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
- +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
- +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
- | +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
- | +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
- | +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
- | +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
- | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
- | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
- | \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
- +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
- | +--- com.github.bumptech.glide:glide:4.12.0
- | | +--- com.github.bumptech.glide:gifdecoder:4.12.0
- | | | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
- | | +--- com.github.bumptech.glide:disklrucache:4.12.0
- | | +--- com.github.bumptech.glide:annotations:4.12.0
- | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
- | | +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
- | | \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
- | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
- | +--- com.github.bumptech.glide:glide:4.12.0 (*)
- | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
- | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
- +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.93.0-alpha1
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | +--- androidx.gridlayout:gridlayout:1.0.0
- | | +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
- | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
- | +--- androidx.cardview:cardview:1.0.0 (*)
- | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
- | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
- | +--- org.wordpress:aztec:v1.6.3 (*)
- | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
- | +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
- | +--- org.wordpress.aztec:glide-loader:v1.6.3
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
- | | +--- org.wordpress:aztec:v1.6.3 (*)
- | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
- \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+ \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.93.0-alpha2
+ +--- com.facebook.fresco:animated-gif:2.0.0
+ | +--- com.parse.bolts:bolts-tasks:1.4.0
+ | +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.facebook.fresco:animated-base:2.0.0
+ | +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | +--- com.facebook.fresco:animated-drawable:2.0.0
+ | | +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+ | | +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+ | | \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+ | \--- com.parse.bolts:bolts-tasks:1.4.0
+ +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+ +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+ | +--- com.google.android.exoplayer:exoplayer:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+ | | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | | \--- com.google.guava:guava:27.1-android
+ | | | | +--- com.google.guava:failureaccess:1.0.1
+ | | | | \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+ | | | \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+ | | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | | \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+ | | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | | \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+ | | \--- androidx.media:media:1.2.1 (*)
+ | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+ | +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+ | +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+ | | +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+ | | +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+ | | \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+ | \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+ +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+ +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+ +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
+ +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
+ +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+ | +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+ | +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+ | +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
+ | +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
+ | +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+ | +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+ | \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+ +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+ | +--- com.github.bumptech.glide:glide:4.12.0
+ | | +--- com.github.bumptech.glide:gifdecoder:4.12.0
+ | | | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+ | | +--- com.github.bumptech.glide:disklrucache:4.12.0
+ | | +--- com.github.bumptech.glide:annotations:4.12.0
+ | | +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+ | | +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+ | | \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+ | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+ | +--- com.github.bumptech.glide:glide:4.12.0 (*)
+ | +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+ | \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+ +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.93.0-alpha2
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | +--- androidx.gridlayout:gridlayout:1.0.0
+ | | +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+ | | \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+ | +--- androidx.cardview:cardview:1.0.0 (*)
+ | +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+ | +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+ | +--- org.wordpress:aztec:v1.6.3 (*)
+ | +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
+ | +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
+ | +--- org.wordpress.aztec:glide-loader:v1.6.3
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+ | | +--- org.wordpress:aztec:v1.6.3 (*)
+ | | \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
Please review and act accordingly
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
To test:
Regression Notes
Potential unintended areas of impact
Block editor
What I did to test those areas of impact (or what existing automated tests I relied on)
Tests in Gutenberg Mobile
What automated tests I added (or what prevented me from doing so)
Rely on tests in Gutenberg Mobile
PR submission checklist:
RELEASE-NOTES.txtif necessary.