[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #17587

fluiddot · 2022-11-30T18:31:17Z

Gutenberg Mobile PR: Only register core blocks when onlyCoreBlocks capability is enabled gutenberg-mobile#5293

To test

The following features in the editor will be disabled when reaching the phase of disabling Jetpack-powered features:

Disable Jetpack blocks
- Remove Jetpack blocks from the block picker
- Display Jetpack blocks as unsupported
Disable @-mentions and X-posts features
Remove Editor’s help support
Remove Reusable blocks
Disable Unsupported Block Editor (UBE)

1 - Editor Jetpack-powered features ENABLED in WordPress app

Preparation

Navigate to App Settings in the WordPress app and open Debug settings.
Turn jp_removal_four and jp_removal_new_users flags off.

Check Jetpack blocks

Create a post.
Tap on ➕ Add Blocks button.
Scroll down the block list.
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post.
Add all Jetpack blocks (Contact Info, Story, Layout Grid blocks).
Observe that all Jetpack blocks are displayed and can be edited.
Save the post with some Jetpack blocks (this post will be used in other test cases).

Check @-mentions and X-posts features

Add a Paragraph block.
Type the + character and observe that the x-post sheet is displayed.
NOTE: x-post feature only works in sites with the O2 plugin enabled like P2-based sites. In order to test this, please use a P2-based site.
Type the @ character and observe that the @-mentions sheet is displayed.
Observe that in the toolbar the @ format button is displayed.

Check the help's support section

Open a post.
Tap on the three dots button to open the contextual menu.
Observe that there's the option Help & Support that references Support, tap on it.
Observe that the section Get support is present.

Check Reusable blocks

Create a reusable block in the web version of the editor (instructions here).
Create a post in the app.
Tap on ➕ Add Blocks button.
Observe that in the bottom sheet the "Reusable" tab is shown.
Tap on the "Reusable" tab and insert a Reusable block.
Observe that the block is displayed.
Save the post with at least one Reusable block (this post will be used in other test cases).

Check Unsupported Block Editor (UBE)

Create a post in the web version of the editor.
Add a block that is not supported in the native version like the Table block.
Save the post (this post will be used in other test cases).
Open the same post in the app.
Observe that the block is displayed as unsupported.
Tap on the block and try to edit it with UBE.
Observe that it can be edited with UBE.

2 - Editor Jetpack-powered features DISABLED in WordPress app

Preparation

Navigate to App Settings in the WordPress app and open Debug settings.
Turn jp_removal_four flag on.

NOTE: It's recommended that the following test cases are also checked by turning the jp_removal_new_users flag on and jp_removal_four flag off in Debug settings.

Check Jetpack blocks

Open the previous post saved with Jetpack blocks.
Observe that the Jetpack blocks are displayed as unsupported.
Tap on a Jetpack block and observe that a bottom sheet is displayed indicating that the block is not supported.
Tap on ➕ Add Blocks button.
Scroll down the block list.
Observe that the Jetpack blocks are NOT present.

Check @-mentions and X-posts features

Add a Paragraph block.
Type the + character and observe that the x-post sheet is NOT displayed.
NOTE: x-post feature only works in sites with the O2 plugin enabled like P2-based sites. In order to test this, please use a P2-based site.
Type the @ character and observe that the @-mentions sheet is NOT displayed.
Observe that in the toolbar the @ format button is NOT displayed.

Check the help's support section

Open a post.
Tap on the three dots button to open the contextual menu.
Observe that there's the option Help but doesn't reference Support, tap on it.
Observe that the section Get support is NOT present.

Check Reusable blocks

Open the previous post saved with Reusable blocks.
Observe that the Reusable block is displayed as unsupported.
Tap on the block and observe that a bottom sheet is displayed indicating that the block is not supported.
Tap on ➕ Add Blocks button.
Observe that in the bottom sheet the "Reusable" tab is NOT shown.

Check Unsupported Block Editor (UBE)

Open the previous post saved with unsupported blocks.
Observe that the block is displayed as unsupported.
Tap on the block and observe that it can't be edited with UBE.

3- Editor Jetpack-powered features ENABLED in Jetpack app

Navigate to App Settings in the Jetpack app and open Debug settings.
Turn jp_removal_four flag on. This flag should be omitted by the Jetpack app.
Repeat the same test cases described in "1 - Editor Jetpack-powered features ENABLED in WordPress app":
- Check Jetpack blocks
- Check @-mentions and X-posts features
- Check the help's support section
- Check Reusable blocks
- Check Unsupported Block Editor (UBE)

Regression Notes

Potential unintended areas of impact
Only the editor should be affected.
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2022-12-07T18:55:34Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17587-8b1c4cd.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`8b1c4cd`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2022-12-07T18:56:55Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17587-8b1c4cd.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`8b1c4cd`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

derekblank · 2022-12-13T07:50:43Z

Thanks for putting this together @fluiddot! I am capturing my testing experiences below. It seems like a few of the steps are not working correctly for me, mostly around when the Jetpack blocks are present -- I'm curious if this matches your testing experiences. For reference, I checked the web version of each of the sites I was testing on and verified that Jetpack was/was not connected and could see Jetpack blocks in the web version when they were expected based on the testing scenarios. I've color-coded which steps succeeded and which steps failed for me. Let me know if I can provide more info:

1 - Editor Jetpack-powered features ENABLED in WordPress app:

Create a post. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🔴
Add some Jetpack blocks. 🔴
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is displayed. 🔴
Type the @ character and observe that the @-mentions sheet is displayed. 🟢
Observe that in the toolbar the @ format button is displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help & Support that references Support, tap on it. 🟢
Observe that the section Get support is present. 🟢
Save the post with some Jetpack blocks and close the editor. 🟡 (no Jetpack blocks present in Block list)

2 - Editor Jetpack-powered features DISABLED in WordPress app:

Navigate to App Settings and open debug settings. 🟢
Turn jp_removal_four flag on. 🟢
Open the previous post saved with Jetpack blocks. ⚪ (see dependent steps on the above test scenario)
Observe that the Jetpack blocks are displayed as unsupported. ⚪
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are NOT present. 🟢
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is NOT displayed. 🟢
Type the @ character and observe that the @-mentions sheet is NOT displayed. 🟢
Observe that in the toolbar the @ format button is NOT displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help but doesn't reference Support, tap on it. 🟢
Observe that the section Get support is NOT present. 🟢

3- Editor Jetpack-powered features ENABLED in Jetpack app:

Navigate to App Settings and open debug settings. 🟢
Turn jp_removal_four flag on. This flag should be omitted by the Jetpack app. 🟢
Create a post. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🔴
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is displayed. 🟢
Type the @ character and observe that the @-mentions sheet is displayed. 🟢
Observe that in the toolbar the @ format button is displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help & Support that references Support, tap on it. 🟢
Observe that the section Get support is present. 🟢

fluiddot · 2022-12-13T12:01:18Z

Thank you @derekblank for testing the changes 🙇 ! I went through the testing instructions again to check the steps that failed for you:

1 - Editor Jetpack-powered features ENABLED in WordPress app:

Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🔴

Add some Jetpack blocks. 🔴

Interesting, I can see the Jetpack blocks in the block inserter menu. Let me know if you could check the following points to identify what's different between our test sessions:

Was the jp_removal_four flag disabled? (I'm going to update the test instructions to make clear that this flag has to be disabled, which should be by default).
Did you encounter this issue when testing on a WPCOM site or a self-hosted site? If the latter, was it connected to Jetpack?
Could you elaborate on what failed? Was that you couldn't see the Jetpack powered section or that some Jetpack blocks weren't present?

1 - Editor Jetpack-powered features ENABLED in WordPress app:

Type the + character and observe that the x-post sheet is displayed. 🔴

I should have highlighted that x-post feature is only available on sites with the O2 plugin enabled like P2-based sites. Could you check this step again on a P2-based site?

1 - Editor Jetpack-powered features ENABLED in WordPress app:

Save the post with some Jetpack blocks and close the editor. 🟡 (no Jetpack blocks present in Block list)

It's not clear to me what happened in this step, was it that you couldn't save Jetpack blocks because there weren't available?

3- Editor Jetpack-powered features ENABLED in Jetpack app:

Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🔴

I understand this could be caused by a similar cause like the one you pointed in 1 - Editor Jetpack-powered features **ENABLED** in **WordPress app*, is it accurate?

It's definitely not expected that in the Jetpack app you can't see the Jetpack blocks. Could you share more info about the type of site you used for testing? Thanks!

zwarm · 2022-12-13T14:42:22Z

@fluiddot I ran across an exception while trying to test. I could not reproduce it, but you might find the following helpful. After the exception, the app locked up and I had to swipe it closed. I could not recreate.

Pixel 5 Android 13

Create a post.
Tap on ➕ Add Blocks button.
Scroll down the block list.
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post.
Added the "contact" info Jetpack block

Exception	Log

fluiddot · 2022-12-13T14:55:49Z

@fluiddot I ran across an exception while trying to test. I could not reproduce it, but you might find the following helpful. After the exception, the app locked up and I had to swipe it closed. I could not recreate.

Thanks for reporting this @zwarm 🙇. I'll take a look and try to reproduce it locally.

fluiddot · 2022-12-14T12:45:57Z

@zwarm I tried to reproduce the NullPointerException crash but it's quite hard to get it constantly. The only way I found where it crashes more often is by having several Contact Info blocks in a post and closing and opening the editor multiple times until it crashes.

However, as far as I investigated, this crash is not new as I found reports in previous versions. Besides, I found a related issue (https://github.com/facebook/react-native/issues/17530) reported in the React Native repository with the same error:

java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.drawable.Drawable android.graphics.drawable.Drawable$ConstantState.newDrawable(android.content.res.Resources)' on a null object reference

The issue seems solved but per recent comments, I understand that is still happening. Plus, I couldn't find information about how to reproduce it or a way to really solve it. Seems that it might have to do with setting transparency in the EditText component but I couldn't relate this to the editor so far.

Being this said, I think we can omit this error for the PR review, I'll open another GitHub issue with this information as a follow-up. Thanks!

Mina012015 · 2022-12-14T23:25:31Z

Ok في الأربعاء، ١٤ ديسمبر، ٢٠٢٢ ٢:٤٦ م Carlos Garcia ***@***.***> كتب:

…

@zwarm <https://github.com/zwarm> I tried to reproduce the NullPointerException crash but it's quite hard to get it constantly. The only way I found where it crashes more often is by having several Contact Info blocks in a post and closing and opening the editor multiple times until it crashes. However, as far as I investigated, this crash is not new as I found reports in previous versions. Besides, I found a related issue ( facebook/react-native#17530) reported in the React Native repository with the same error: java.lang.NullPointerException: Attempt to invoke virtual method 'android.graphics.drawable.Drawable android.graphics.drawable.Drawable$ConstantState.newDrawable(android.content.res.Resources)' on a null object reference The issue seems solved but per recent comments, I understand that is still happening. Plus, I couldn't find information about how to reproduce it or a way to really solve it. Seems that it might have to do with setting transparency in the EditText component but I couldn't relate this to the editor so far. Being this said, *I think we can omit this error for the PR review*, I'll open another GitHub issue with this information as a follow-up. Thanks! — Reply to this email directly, view it on GitHub <#17587 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4WLNS6H2NI4QAKC5K66WXDWNG6RXANCNFSM6AAAAAASP54EQM> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

derekblank · 2022-12-15T08:13:00Z

Interesting, I can see the Jetpack blocks in the block inserter menu. Let me know if you could check the following points to identify what's different between our test sessions:

Was the jp_removal_four flag disabled? (I'm going to update the test instructions to make clear that this flag has to be disabled, which should be by default).

Did you encounter this issue when testing on a WPCOM site or a self-hosted site? If the latter, was it connected to Jetpack?

Could you elaborate on what failed? Was that you couldn't see the Jetpack powered section or that some Jetpack blocks weren't present?

After re-reading this feedback and exploring the Debug menu more, I realized that after disabling the jp_removal_four feature flag, I did not know to scroll and select "Restart the App". To answer the other questions, I did encounter this on both a WPCOM and a self-hosted site with Jetpack connected. In both cases, I believe the issue was I did not restart the app after disabling the feature flag. When re-testing after doing this, I was able to Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🟢 and Add some Jetpack blocks. 🟢

Save the post with some Jetpack blocks and close the editor. 🟡 (no Jetpack blocks present in Block list)
It's not clear to me what happened in this step, was it that you couldn't save Jetpack blocks because there weren't available?

Correct, initially I was simply unable to complete this step as in my first testing setup, there were no Jetpack blocks present to test, so I marked it 🟡 . After retesting (from the feedback above), this step is now also green. 🟢

Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🔴
I understand this could be caused by a similar cause like the one you pointed in 1 - Editor Jetpack-powered features ENABLED in *WordPress app, is it accurate?

Correct, same issue as above. This step is now green after retesting. 🟢

Type the + character and observe that the x-post sheet is displayed. 🔴
I should have highlighted that x-post feature is only available on sites with the O2 plugin enabled like P2-based sites. Could you check this step again on a P2-based site?

After retesting, this is the only remaining 🔴 / 🟡 for me. I am having trouble installing the O2 plugin based on the documentation on my WPCOM and self-hosted sites. Based on internal references, it appears the p2-breathe theme is deprecated, which is the blocker. However, when using a draft post on P2-based site where I know O2 is already installed, I am able to succeed on this step, which I think should be sufficient to mark all of these steps as green. 🟢 WDYT?

fluiddot · 2022-12-15T17:57:49Z

Thanks @derekblank for re-testing this PR, I really appreciate it 🙇.

I'd like to note that following this comment, I'd need to update this PR to include the flag newUsers to the condition for determining if the Jetpack-powered features should be disabled. Once I execute this change I'll let you know in case you could perform a last review. Thanks!

After re-reading this feedback and exploring the Debug menu more, I realized that after disabling the jp_removal_four feature flag, I did not know to scroll and select "Restart the App"

Oh, that's interesting. In my case, I didn't need to restart the app after enabling/disabling the flags 🤔. In any case, I'm glad that doing that and after re-testing, most of the steps succeeded. In relation to this, would you mind updating your comment or posting another one to reflect the latest status of your testing? Thanks!

After retesting, this is the only remaining 🔴 / 🟡 for me. I am having trouble installing the O2 plugin based on the documentation on my WPCOM and self-hosted sites. Based on internal references, it appears the p2-breathe theme is deprecated, which is the blocker. However, when using a draft post on P2-based site where I know O2 is already installed, I am able to succeed on this step, which I think should be sufficient to mark all of these steps as green. 🟢 WDYT?

To be honest, I simply tested this by creating a post on a P2-based site, any of them should work. Therefore, if you managed to make this work on that type of site, I agree it's enough to mark this step as succeeded 🟢 .

derekblank · 2022-12-16T06:16:09Z

After retesting the latest build, the following steps are all green:

1 - Editor Jetpack-powered features ENABLED in WordPress app:

Create a post. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🟢
Add some Jetpack blocks. 🟢
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is displayed. 🟢
Type the @ character and observe that the @-mentions sheet is displayed. 🟢
Observe that in the toolbar the @ format button is displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help & Support that references Support, tap on it. 🟢
Observe that the section Get support is present. 🟢
Save the post with some Jetpack blocks and close the editor. 🟢

2 - Editor Jetpack-powered features DISABLED in WordPress app:

Navigate to App Settings and open debug settings. 🟢
Turn jp_removal_four flag on. 🟢
Open the previous post saved with Jetpack blocks. 🟢
Observe that the Jetpack blocks are displayed as unsupported. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are NOT present. 🟢
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is NOT displayed. 🟢
Type the @ character and observe that the @-mentions sheet is NOT displayed. 🟢
Observe that in the toolbar the @ format button is NOT displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help but doesn't reference Support, tap on it. 🟢
Observe that the section Get support is NOT present. 🟢

3- Editor Jetpack-powered features ENABLED in Jetpack app:

Navigate to App Settings and open debug settings. 🟢
Turn jp_removal_four flag on. This flag should be omitted by the Jetpack app. 🟢
Create a post. 🟢
Tap on ➕ Add Blocks button. 🟢
Scroll down the block list. 🟢
Observe that the Jetpack blocks are present within the Jetpack powered section section and can be added to the post. 🟢
Add a Paragraph block. 🟢
Type the + character and observe that the x-post sheet is displayed. 🟢
Type the @ character and observe that the @-mentions sheet is displayed. 🟢
Observe that in the toolbar the @ format button is displayed. 🟢
Tap on the three dots button to open the contextual menu. 🟢
Observe that there's the option Help & Support that references Support, tap on it. 🟢
Observe that the section Get support is present. 🟢

derekblank · 2022-12-16T06:21:19Z

I'd like to note that following this comment, I'd need to update this PR to include the flag newUsers to the condition for determining if the Jetpack-powered features should be disabled. Once I execute this change I'll let you know in case you could perform a last review. Thanks!

Makes sense, I will keep an eye out and retest when ready.

In relation to this, would you mind updating #17587 (comment) or posting another one to reflect the latest status of your testing? Thanks!

I've posted a new comment clarifying that all steps are green from my latest testing. I think preserving the status of the original testing comment could possibly help in the future (instead of editing it). 👍

To be honest, I simply tested this by creating a post on a P2-based site, any of them should work. Therefore, if you managed to make this work on that type of site, I agree it's enough to mark this step as succeeded 🟢 .

Yep, I agree, and was able to retest this successfully. I am happy to review this PR as Approved, unless you'd like to await for the newUser changes mentioned above to be retested -- let me know what you think. 🙇

fluiddot · 2022-12-16T17:28:21Z

I am happy to review this PR as Approved, unless you'd like to await for the newUser changes wordpress-mobile/WordPress-iOS#19691 (comment) to be retested -- let me know what you think. 🙇

@derekblank I'd rather wait for all changes to be executed before heading to the approval, thanks!

fluiddot · 2022-12-16T19:34:10Z

I am happy to review this PR as Approved, unless you'd like to await for the newUser changes wordpress-mobile/WordPress-iOS#19691 (comment) to be retested -- let me know what you think. 🙇

@derekblank I'd rather wait for all changes to be executed before heading to the approval, thanks!

All changes applied. The PR is ready for another review, thanks 🙇 !

derekblank

LGTM! 🚀

geriux · 2022-12-29T08:37:35Z

Hey there @fluiddot 👋 Quick question, is the Add new Story post button going to disabled in another PR? It is being shown using the WordPress app with the jp_removal_four and jp_removal_new_users flags enabled.

geriux

Test cases worked correctly ✅ I only left one question in #17587 (comment)

fluiddot · 2022-12-29T08:56:35Z

Hey there @fluiddot 👋 Quick question, is the Add new Story post button going to disabled in another PR? It is being shown using the WordPress app with the jp_removal_four and jp_removal_new_users flags enabled.

@geriux Yes, the Story post button is going to also be disabled but that will be done in another PR. In this one, I only wanted to disable the editor features.

wpmobilebot · 2022-12-29T20:08:43Z

Found 1 violations:

The PR caused the following dependency changes:

 \--- project :libs:editor
-     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.86.0
-          +--- com.facebook.fresco:animated-gif:2.0.0
-          |    +--- com.parse.bolts:bolts-tasks:1.4.0
-          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |    \--- com.facebook.fresco:animated-base:2.0.0
-          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         +--- com.facebook.fresco:animated-drawable:2.0.0
-          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-          |         \--- com.parse.bolts:bolts-tasks:1.4.0
-          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
-          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    |    \--- com.google.guava:guava:27.1-android
-          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-          |    |         \--- androidx.media:media:1.2.1 (*)
-          |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
-          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
-          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
-          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
-          +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-2
-          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
-          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
-          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-2
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-          |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
-          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
-          |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
-          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
-          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
-          |    +--- com.github.bumptech.glide:glide:4.12.0
-          |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
-          |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-          |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
-          |    |    +--- com.github.bumptech.glide:annotations:4.12.0
-          |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
-          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-          |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
-          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-          |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
-          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
-          |         \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
-          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.86.0
-          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-          |    +--- androidx.gridlayout:gridlayout:1.0.0
-          |    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
-          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-          |    +--- androidx.cardview:cardview:1.0.0 (*)
-          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
-          |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
-          |    +--- org.wordpress:aztec:v1.6.2 (*)
-          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.2 (*)
-          |    +--- org.wordpress.aztec:wordpress-comments:v1.6.2 (*)
-          |    +--- org.wordpress.aztec:glide-loader:v1.6.2
-          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
-          |    |    +--- org.wordpress:aztec:v1.6.2 (*)
-          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
-          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
-          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+     \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.87.0-alpha1
+          +--- com.facebook.fresco:animated-gif:2.0.0
+          |    +--- com.parse.bolts:bolts-tasks:1.4.0
+          |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+          |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |    \--- com.facebook.fresco:animated-base:2.0.0
+          |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         +--- com.facebook.fresco:animated-drawable:2.0.0
+          |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+          |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+          |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+          |         \--- com.parse.bolts:bolts-tasks:1.4.0
+          +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+          +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+          |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+          |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    |    \--- com.google.guava:guava:27.1-android
+          |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+          |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+          |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+          |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+          |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+          |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+          |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |         +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+          |    |         \--- androidx.media:media:1.2.1 (*)
+          |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    +--- androidx.core:core:1.1.0 -> 1.7.0 (*)
+          |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+          |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+          |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+          |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.2.0
+          |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+          |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+          +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+          +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+          +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-2
+          +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+          |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.3.1 (*)
+          +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+          |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-2
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+          |    +--- androidx.core:core-ktx:1.6.0 -> 1.7.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+          |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.3.1 (*)
+          |    +--- androidx.fragment:fragment:1.2.1 -> 1.4.1 (*)
+          |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+          |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+          |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+          +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+          |    +--- com.github.bumptech.glide:glide:4.12.0
+          |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
+          |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+          |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
+          |    |    +--- com.github.bumptech.glide:annotations:4.12.0
+          |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.4.1 (*)
+          |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+          |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+          |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+          |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
+          |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+          |         \--- androidx.annotation:annotation:1.0.0 -> 1.2.0
+          +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.87.0-alpha1
+          |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+          |    +--- androidx.gridlayout:gridlayout:1.0.0
+          |    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+          |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+          |    +--- androidx.cardview:cardview:1.0.0 (*)
+          |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.3.1 (*)
+          |    +--- androidx.recyclerview:recyclerview:1.1.0 (*)
+          |    +--- org.wordpress:aztec:v1.6.2 (*)
+          |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.2 (*)
+          |    +--- org.wordpress.aztec:wordpress-comments:v1.6.2 (*)
+          |    +--- org.wordpress.aztec:glide-loader:v1.6.2
+          |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.20 -> 1.6.21 (*)
+          |    |    +--- org.wordpress:aztec:v1.6.2 (*)
+          |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+          |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+          \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)

Please review and act accordingly

Updates: the logic to add jetpack powered blocks ability in static poster phase This commit is based on this commit 4418fbd from this PR - #17587 which disabled the jetpack powered editor features on phase 4 Added a helper function to disable the Jp powered editor features in pages and replaced the usages of `shouldRemoveJetpackFeatures` with `shouldShowJetpackPoweredEditorFeatures`

fluiddot added the gutenberg-mobile label Nov 30, 2022

fluiddot added this to the 21.5 milestone Nov 30, 2022

fluiddot self-assigned this Nov 30, 2022

fluiddot mentioned this pull request Dec 2, 2022

Only register core blocks when onlyCoreBlocks capability is enabled wordpress-mobile/gutenberg-mobile#5293

Merged

2 tasks

fluiddot force-pushed the gutenberg/disable-jp-editor-features branch from 2d377ac to 7e0c78e Compare December 12, 2022 15:54

fluiddot marked this pull request as ready for review December 12, 2022 15:54

fluiddot added the [Status] Not Ready for Merge label Dec 12, 2022

fluiddot requested review from derekblank and geriux December 16, 2022 19:31

derekblank approved these changes Dec 22, 2022

View reviewed changes

fluiddot added 4 commits December 27, 2022 16:46

Disable editor features via Gutenberg capabilities

4418fbd

Use different help title depending on removal phase

70cb383

Fix code style issues

774cbcd

Add helper to determine when Jetpack features should be removed

dc553f6

fluiddot force-pushed the gutenberg/disable-jp-editor-features branch from 09f3428 to 193accd Compare December 27, 2022 16:35

Update Gutenberg Mobile ref

052632b

fluiddot force-pushed the gutenberg/disable-jp-editor-features branch from 193accd to 052632b Compare December 27, 2022 16:44

geriux approved these changes Dec 29, 2022

View reviewed changes

Update Gutenberg Mobile ref with tag

8b1c4cd

fluiddot removed the [Status] Not Ready for Merge label Dec 29, 2022

fluiddot merged commit dfb4746 into trunk Dec 30, 2022

fluiddot deleted the gutenberg/disable-jp-editor-features branch December 30, 2022 09:10

AjeshRPai mentioned this pull request Jan 19, 2023

Jetpack Focus: Remove Jetpack features during phase 4 #17339

Closed

24 tasks

fluiddot mentioned this pull request Mar 9, 2023

[Gutenberg] Allow audio upload to premium users after Jetpack features removal #18075

Merged

3 tasks

zwarm mentioned this pull request Mar 17, 2023

Disable features on static posters phase #18132

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #17587

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #17587

fluiddot commented Nov 30, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

derekblank commented Dec 13, 2022 •

edited

Loading

fluiddot commented Dec 13, 2022

zwarm commented Dec 13, 2022

fluiddot commented Dec 13, 2022

fluiddot commented Dec 14, 2022

Mina012015 commented Dec 14, 2022 via email

derekblank commented Dec 15, 2022 •

edited

Loading

fluiddot commented Dec 15, 2022

derekblank commented Dec 16, 2022

derekblank commented Dec 16, 2022

fluiddot commented Dec 16, 2022

fluiddot commented Dec 16, 2022

derekblank left a comment

geriux commented Dec 29, 2022

geriux left a comment

fluiddot commented Dec 29, 2022

wpmobilebot commented Dec 29, 2022

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #17587

[Gutenberg] Disable editor Jetpack-powered features based on Jetpack Features Removal phases #17587

Conversation

fluiddot commented Nov 30, 2022 • edited Loading

To test

1 - Editor Jetpack-powered features ENABLED in WordPress app

Preparation

Check Jetpack blocks

Check @-mentions and X-posts features

Check the help's support section

Check Reusable blocks

Check Unsupported Block Editor (UBE)

2 - Editor Jetpack-powered features DISABLED in WordPress app

Preparation

Check Jetpack blocks

Check @-mentions and X-posts features

Check the help's support section

Check Reusable blocks

Check Unsupported Block Editor (UBE)

3- Editor Jetpack-powered features ENABLED in Jetpack app

Regression Notes

wpmobilebot commented Dec 7, 2022 • edited Loading

wpmobilebot commented Dec 7, 2022 • edited Loading

derekblank commented Dec 13, 2022 • edited Loading

fluiddot commented Dec 13, 2022

zwarm commented Dec 13, 2022

fluiddot commented Dec 13, 2022

fluiddot commented Dec 14, 2022

Mina012015 commented Dec 14, 2022 via email

derekblank commented Dec 15, 2022 • edited Loading

fluiddot commented Dec 15, 2022

derekblank commented Dec 16, 2022

derekblank commented Dec 16, 2022

fluiddot commented Dec 16, 2022

fluiddot commented Dec 16, 2022

derekblank left a comment

Choose a reason for hiding this comment

geriux commented Dec 29, 2022

geriux left a comment

Choose a reason for hiding this comment

fluiddot commented Dec 29, 2022

wpmobilebot commented Dec 29, 2022

The PR caused the following dependency changes:

fluiddot commented Nov 30, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

wpmobilebot commented Dec 7, 2022 •

edited

Loading

derekblank commented Dec 13, 2022 •

edited

Loading

derekblank commented Dec 15, 2022 •

edited

Loading