-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle Wrapper Validation #17480
Gradle Wrapper Validation #17480
Conversation
📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17480-3f049a1.apk
|
📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17480-3f049a1.apk
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @oguzkocer !
Great work on the adding the Gradle Wrapper Validation
checks in WPAndroid! 🥇 ❤️ 🚀
I've reviewed and tested the PR as per the description and everything LGTM:
- Configuration Changes ✅
- Buildkite ✅
- GitHub Actions ✅
After this PR is merged, I suggest we add the Github Action as a required step for trunk branch.
I totally agree! 💯
In Automattic/a8c-ci-toolkit-buildkite-plugin#34 we introduced our own script to validate the Gradle Wrapper which uses the official documentation for its implementation. This PR uses that script to add a prerequisite step to validate the Gradle Wrapper in all 3 pipelines.
The main reason we decided to add our own script as opposed to using the official Github Action was to be able to validate the Gradle Wrapper before running any of the Buildkite steps. As discussed in that PR, there are some edge cases our script doesn't cover. Furthermore, because it's a custom implementation, there is always a chance that it gets outdated. Therefore, we are adding the official Github Action alongside our own script.
After this PR is merged, I suggest we add the Github Action as a required step for
trunk
branch. The Buildkite step is already a prerequisite for the rest of the steps, so I don't think we need to add it as a required check, but having the Github Action as a required check should give us some extra peace of mind. Github only takes~20s
to validate the wrapper, so it shouldn't block developers unless there is an issue with it.To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.