Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Hide audio block on free sites #14037

Merged

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Feb 11, 2021

gb-mobile PR: wordpress-mobile/gutenberg-mobile#3129

Hide audio block on free sites.

Testing

  1. Switch to a free/simple site
  2. Open editor
  3. Tap block inserter
  4. Audio Block should not be in the list

  1. Switch to a paid/self-hosted site
  2. Open editor
  3. Tap block inserter
  4. Audio Block should be in the list

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 11, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jd-alexander
Copy link
Contributor

@ceyhun I will have to branch from this PR by @mzorz #14034 because this gutenberg-mobile submodule hash only contains the changes for the release and it doesn't contain the story related changes that haven't been reverted as yet so the Android build is failing. So yes, I will change the base of this. I am just making a note of this here for review purposes 😄

@jd-alexander
Copy link
Contributor

I'm now seeing where the revert will not be done and the changes will be included so I'm going to double check on the gutenberg-mobile side of things for verification to resolve this error.

@jd-alexander
Copy link
Contributor

jd-alexander commented Feb 12, 2021

@ceyhun based on this comment

Will change base to release/1.46.1 branch when it's ready.

on the gutenberg-mobile PR I went ahead and added the Android changes here and I was able to test locally by removing code that was causing the build to fail due to the Story changes not being present. I am also testing the self-hosted flow to verify all is well there.

Once the changes have been either reverted or added and release/1.46.1 has been finalized this PR can be retested.

@jd-alexander jd-alexander added this to the 16.7 ❄️ milestone Feb 12, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 15, 2021

You can test the changes on this Pull Request by downloading the APK here.

@jd-alexander
Copy link
Contributor

@ceyhun do you want to give this a test as well? All is working from my side with the following flows:

  1. WPCom simple site with a free plan. - Audio block is not shown in the inserter.
  2. WPCom simple site using a paid plan - Audio block is shown in the inserter.
  3. Self-hosted site - Audio block is shown in the inserter.

@ceyhun
Copy link
Contributor Author

ceyhun commented Feb 15, 2021

@jd-alexander working fine from my side as well 👍

@ceyhun ceyhun changed the base branch from release/16.7 to gutenberg/integrate_release_1.46.1 February 15, 2021 17:03
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Awaiting confirmation that the gutenberg-mobile and gutenberg are in sync and good to go!

@jd-alexander jd-alexander merged commit c018009 into gutenberg/integrate_release_1.46.1 Feb 16, 2021
@jd-alexander jd-alexander deleted the feature/show-hide-audio-block branch February 16, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants