Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Add Cover block media settings #13818

Merged
merged 12 commits into from
Feb 15, 2021
Merged

[Gutenberg] Add Cover block media settings #13818

merged 12 commits into from
Feb 15, 2021

Conversation

dcalhoun
Copy link
Member

Fixes wordpress-mobile/gutenberg-mobile#1741

To test: Test plan in Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 19, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@dcalhoun dcalhoun mentioned this pull request Jan 19, 2021
Closed
3 tasks
This was referenced Jan 19, 2021
Merged
Merged
@ghost ghost mentioned this pull request Jan 19, 2021
Merged
6 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 19, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@dcalhoun dcalhoun marked this pull request as ready for review January 19, 2021 23:06
@dcalhoun dcalhoun requested a review from geriux January 19, 2021 23:06
@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from 9550091 to 7e4fc5c Compare January 29, 2021 22:13
@dcalhoun dcalhoun self-assigned this Feb 3, 2021
@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from 55a72d7 to c2d7f14 Compare February 11, 2021 13:09
@dcalhoun dcalhoun assigned geriux and unassigned dcalhoun Feb 11, 2021
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

geriux
geriux approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#25810 (review)

@dcalhoun dcalhoun merged commit 735ba3a into develop Feb 15, 2021
@dcalhoun dcalhoun deleted the gutenberg/media-settings branch February 15, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@geriux geriux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cover block: Add media settings(fixed background and focal point picker)
2 participants
@dcalhoun @geriux