-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter for images and video in add media picker #10576
Merged
Merged
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ffdb7b2
Add addMediaClicked method to editor fragment listener interface
mkevins 7e5be37
Implement addMediaClicked methods
mkevins 91b564a
Implement prepareMediaLibrary intent for image/video picker
mkevins 537354c
Implement launchMediaLibrary for device media picker
mkevins 1b02316
Fix typo
mkevins aaab02f
Update gutenberg-mobile reference
mkevins e59409e
Update gutenberg-mobile reference
mkevins 3c47b61
Rename device media method
mkevins d34e129
Add library media interface method
mkevins 151f553
Use EDITOR_PICKER for media library button
mkevins 8c96815
Update gutenberg-mobile reference
mkevins 7536e7e
Add media browser type for single media picker
mkevins e70b135
Use single picker when multiple is false
mkevins c5b70df
Return media id on short tap
mkevins c16f4cc
Merge pull request #10597 from wordpress-mobile/try/fix-media-text-bo…
mkevins f2c86e4
Update gutenberg-mobile reference
mkevins 1e38e0e
Update string value for adding media
mkevins b96689e
Merge branch 'develop' into try/fix-media-text-device-picker
mkevins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule gutenberg-mobile
updated
5 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely not familiar enough with Android and I'd recommend another reviewer, but I was aware of the MediaBrowserType enum, and I see that the other addMedia methods use
ActivityLauncher.viewMediaPickerForResult
instead. Is there a reason not to use the same thing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great question! The
viewMediaPickerForResult
method actually prepares an intent with the "in-house"MediaBrowserActivity
(i.e. "WordPress Media Library"). At first glance at the code, I had the same thought, and that may be an indication that the name is ambiguous. OTOH, I'm not sure I can offer a better name, since theMediaBrowserActivity
itself has menu items that call through to the device picker (which, incidentally, use theWPMediaUtils
methods).Also, I will take your advice about adding an Android reviewer (more familiar with this area of the code base) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "WordPress Media Library" flow has also been addressed in this PR.