Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strikethrough to default to <s> tag #919

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Jul 21, 2020

Fixes part of wordpress-mobile/gutenberg-mobile#729

Description

This change updates the strikethrough button to default to <s> tag instead of <del> tag. This brings AztecEditor-Android inline with AztecEditor-iOS and HTML5 standards.

To Test

Case 1:

  1. Press Strikethrough button and add some text, note strikethrough works correctly
  2. Switch to HTML mode, note that Aztec shows <s></s> tag around strikethrough text where it would previously have a <del> tag

Case 2:

  1. Switch to HTML mode, add some text with a <del></del> tag around it (or update text with <s></s> around it to be <del></del> instead).
  2. Switch back to visual mode and note that text is still displayed as crossed out, as expected.

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@cameronvoell cameronvoell added android version difference Gutenberg This issue is also valid importing Aztec in Gutenberg labels Jul 21, 2020
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything works well. Thanks @cameronvoell ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android version difference Gutenberg This issue is also valid importing Aztec in Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants