-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make em
the default tag for italic
#777
Conversation
Updated the PR, expanded it to make 👋 @daniloercoli , you think you can make a review pass on this one? Thanks! |
Nice! With tests updated this PR can be 🚢ed! Feel free to merge once the conflicts are resolved. |
Thanks for the review @daniloercoli ! Let's hold off merging this until the parent PR is also ready to merge wordpress-mobile/gutenberg-mobile#275. This way we can avoid a potential revert in case the parent PR doesn't get merged. |
We're giving the "go ahead with merging" for the Gutenberg and gutenberg-mobile side PRs so, merging this. |
Fix
Gutenberg has
<em>
defined as the tag for italic formatting. Aztec can handle<em>
but converts it to<i>
when sending back the html to gutenberg-mobile. This causes inconsistencies in the UI and should be addressed.Test
gutenberg-mobile
PR Use format-library for the formatting bar gutenberg-mobile#275gutenberg-mobile
:formatting
Review
@hypest