Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant context from AztecDynamicImageSpan #1087

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Jul 19, 2024

Fix

It looks like the context in AztecDynamicImageSpan was never used, but we still pass it from all the spans that are based on AztecDynamicImageSpan. This is a vector for memory leaks, so I'm removing it.

Test

  1. Make sure the app builds, and all the spans look normal.
  2. Make sure the changes make sense.

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @khaykov 👏

I tested according to instructions, as well as two devices side-by-side (this branch and trunk). No differences in behavior. 👍

@zwarm zwarm merged commit db247eb into trunk Jul 22, 2024
14 checks passed
@zwarm zwarm deleted the issue/remove-redundant-context-form-image-span branch July 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants