Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Update Kotlin to 1.9.24 #1083

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Jul 8, 2024

Required By: #1084

This PR updates Kotlin to 1.9.22.

Description

This update isn't that necessary, but should be considered anyway as it will do the following:

  • Align this library, to that Kotlin version, which is already used by most of this library's clients and libraries.
  • Unblock the usage of the Dependency Analysis Gradle plugin for this project.
  • Prepares this project for the Kotlin 2+ major update.

Test

  • Smoke test the app example app.
  • Verifying that all the CI checks are successful.
  • However, if you want to be thorough about reviewing this change, you could:
    • Quickly smoke test, either the JP/WPAndroid and/or DOAndroid apps, with this version of Aztec, or via composite builds, and see if it works as expected.
    • Test for build time increases (local & CI).

This update isn't that necessary, but should be considered anyway as it
will do the following:
- Align this library, to that Kotlin version, which is already used by
most of this library's clients and libraries.
- Unblock the usage of the dependency analysis Gradle plugin for this
project.
- Prepares this project for the Kotlin 2+ major update.
This change is necessary because otherwise the build fails with the
below exception:

------------------------------------------------------------------------

> Task :aztec:compileDebugKotlin FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':aztec:compileDebugKotlin'.
> Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (1.8) and 'compileDebugKotlin' (17).

  Consider using JVM Toolchain: https://kotl.in/gradle/jvm/toolchain
  Learn more about JVM-target validation: https://kotl.in/gradle/jvm/
   target-validation
settings.gradle Outdated Show resolved Hide resolved
Co-authored-by: Wojciech Zięba <wojciech.zieba@protonmail.com>
@ParaskP7 ParaskP7 changed the title [Build] Update Kotlin to 1.9.22 [Build] Update Kotlin to ~~1.9.22~~ 1.9.24 Jul 9, 2024
@ParaskP7 ParaskP7 changed the title [Build] Update Kotlin to ~~1.9.22~~ 1.9.24 [Build] Update Kotlin to 1.9.24 Jul 9, 2024
@ParaskP7 ParaskP7 merged commit 9cd15d3 into trunk Jul 9, 2024
14 checks passed
@ParaskP7 ParaskP7 deleted the build/update-kotlin-to-1.9.22 branch July 9, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants