Fix highlight function in the editor #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaykov
approved these changes
Aug 10, 2023
| ) : BackgroundColorSpan(ContextCompat.getColor(context, highlightStyle.color)), IAztecInlineSpan { | ||
| val colorHex: Int | ||
| ) : BackgroundColorSpan(colorHex), IAztecInlineSpan { | ||
| var alpha: Int = 220 |
There was a problem hiding this comment.
I believe this alpha value is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Highlight action was only partially implemented in the Aztec editor. This PR fixes that. The color for highlight can come from 2 places. It's either set in parameters or it can be passed as part of the css styles (this takes precedence over android styles).
Test
Test this with the linked PR
Review
@[USER_NAME]
Make sure strings will be translated:
strings.xmlas a part of the integration PR.