Update compile sdk to 33 #1037

irfano · 2023-03-13T14:24:43Z

Fix

This updates compileSdk to 33 and makes the required changes.

Deprecated getExternalStoragePublicDirectory() warning was suppressed and opened an issue. It's a low-priority task since it's on the sample activity.
LayoutParams.SOFT_INPUT_ADJUST_RESIZE was deprecated in API level 30. I suppressed it at first but then found a way to resolve it.

Test

Being able to build and basic smoke test should be enough.
Updating LayoutParams.SOFT_INPUT_ADJUST_RESIZE may be worth a special test. To test:

Run AztecDemo.
Scroll down and find the HTML block (It's shown as "?", below "if (value == 5) printf(value)")
Tap the HTML block and type a long text to increase the dialog size.
Ensure "CANCEL", "SAVE" buttons are still visible and there is a margin between the keyboard and dialog.

Review

@ParaskP7

Make sure strings will be translated:

If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

"primaryClip" was converted to val after API 28.

Uri's path has been converted to null after API 28.

Handler's removeCallbacks function don't accept nullable runnable after API 28.

Some functions has converted to nullable after API 28.

Some MetricAffectingSpan functions have changed after API 28.

Some LineBackgroundSpan functions have changed after API 28.

Creating Handler with empty constructor was deprecated. It was resolved to adding Looper.getMainLooper() as looper to the construction.

This deprecated warning is suppressed, that is, instead of being resolved, since a resolution would require a proper migration.

Activity's onBackPressed was deprecated on Android 13.

irfano · 2023-03-13T14:38:32Z

👋🏻 @khaykov!
Can I know your comment about a feature you updated recently? You just commented and uncommented, but maybe you can still help.

WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE was deprecated. I want to update it in the recommended way as below.

This constant was deprecated in API level 30.
Call Window#setDecorFitsSystemWindows(boolean) with false and install an OnApplyWindowInsetsListener on your root content view that fits insets of type Type#ime().

I want to test its effect to be sure it still works as expected, but I couldn't find what this line does exactly. It should resize the block editor position on the screen when the keyboard is shown up, so I removed this line and also removed windowSoftInputMode on AndroidManifest but couldn't see any behavior difference.

AztecEditor-Android/aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt

Line 2148 in 46a82a3

    
           blockEditorDialog?.window?.setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_ADJUST_RESIZE)

Do you know how I can test what this line does?

khaykov · 2023-03-13T14:55:11Z

Hey @irfano ! I remember that one :) I was testing updating compileSdk to see if it will fix an issue we had with Samsung devices (it didn't), and that line gave me some compile-time trouble, so I commented it out locally. It made it's way into the commit by accident so I just reverted it back. Sorry, I can't really help you with the setSoftInputMode, since I'm not familiar with block editor logic at all :)

LayoutParams.SOFT_INPUT_ADJUST_RESIZE was deprecated on API 30. Using "View.OnApplyWindowInsetsListener" is the recommended way to update it but it requires activity.window that we can't access from AztecsText. It suppressed for now until the migration will be mandatory.

LayoutParams.SOFT_INPUT_ADJUST_RESIZE was deprecated in API level 30. A theme added to the dialog to keep the same behavior.

irfano · 2023-03-14T20:56:24Z

Hey @irfano ! I remember that one :) I was testing updating compileSdk to see if it will fix an issue we had with Samsung devices (it didn't), and that line gave me some compile-time trouble, so I commented it out locally. It made it's way into the commit by accident so I just reverted it back. Sorry, I can't really help you with the setSoftInputMode, since I'm not familiar with block editor logic at all :)

Thank you @khaykov! I found out its function and explained it in the "Test" section.

ParaskP7

👋 @irfano !

I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟 🌟 🌟

I have left just one suggestion (💡) for you to consider with lots of praise (❤️)! I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.

ParaskP7 · 2023-03-21T13:03:06Z

app/src/main/kotlin/org/wordpress/aztec/demo/MainActivity.kt

+                // gesture feature.
+                isEnabled = false
+                onBackPressedDispatcher.onBackPressed()
+                isEnabled = true


Praise (❤️): You are becoming a pro at that, aren't you! 😃

Suggestion (💡): Maybe creating a CompatExtensions.kt utility class on Aztec, with a onBackPressedCompat(...) extension function, copy-pasting it from here, is the right move for this repo too, just to keep this consistent across every repo, wdyt? 🤔 PS: I know this might seem an overkill as it only applies to this specific and single instance of such onBackPressedDispatcher functionality within this repo, so if you want to skip it instead, I would totally understand.

Praise (❤️): You are becoming a pro at that, aren't you! 😃

and you're becoming a pro at reviewing that. 😁

Suggestion (💡): Maybe creating a CompatExtensions.kt utility class on Aztec, with a onBackPressedCompat(...) extension function, copy-pasting it from here, is the right move for this repo too, just to keep this consistent across every repo, wdyt?

Good advice, but this code is already in the demo app, which consists of only one package and four files. Therefore, I will choose to avoid adding a new file.

ParaskP7 · 2023-03-21T13:04:22Z

aztec/src/main/kotlin/org/wordpress/aztec/AztecText.kt

@@ -2099,7 +2098,7 @@ open class AztecText : AppCompatEditText, TextWatcher, UnknownHtmlSpan.OnUnknown

    @SuppressLint("InflateParams")
    fun showBlockEditorDialog(unknownHtmlSpan: UnknownHtmlSpan, html: String = "") {
-        val builder = AlertDialog.Builder(context)
+        val builder = AlertDialog.Builder(context, R.style.ResizableDialogTheme)


Praise (❤️): Thanks for taking the time to resolve this suppression with the most appropriate fix for this specific case, you rock! 🥇

irfano added 13 commits March 13, 2023 16:34

Upgrade compileSdk to 31

cf421f2

Resolve "Val cannot be reassigned" for primaryClip

c6e555b

"primaryClip" was converted to val after API 28.

Resolve nullable uri path error

46a82a3

Uri's path has been converted to null after API 28.

Update Handler's removeCallbacks function

15abb1c

Handler's removeCallbacks function don't accept nullable runnable after API 28.

Update InputConnection interface functions

4b571fc

Some functions has converted to nullable after API 28.

Update MetricAffectingSpan's functions

4127a13

Some MetricAffectingSpan functions have changed after API 28.

Update LineBackgroundSpan's functions

e254568

Some LineBackgroundSpan functions have changed after API 28.

Resolve nullable warnings for API 31 migration

a88ab84

Update onRestoreInstanceState function for API 31 migration

40facda

Resolve handler deprecated warnings

6efbf9f

Creating Handler with empty constructor was deprecated. It was resolved to adding Looper.getMainLooper() as looper to the construction.

Suppress deprecated warning for getExternalStoragePublicDirectory()

ec7529f

This deprecated warning is suppressed, that is, instead of being resolved, since a resolution would require a proper migration.

Upgrade compileSdk to 33

c013709

Migrate to OnBackPressedCallback

bfadd9f

Activity's onBackPressed was deprecated on Android 13.

irfano added 2 commits March 14, 2023 21:26

Use theme to migrate deprecated SOFT_INPUT_ADJUST_RESIZE

0d2a0db

LayoutParams.SOFT_INPUT_ADJUST_RESIZE was deprecated in API level 30. A theme added to the dialog to keep the same behavior.

irfano marked this pull request as ready for review March 14, 2023 20:54

irfano requested a review from ParaskP7 March 14, 2023 20:54

irfano mentioned this pull request Mar 15, 2023

Upgrade AztecEditor-Android to Android 13 #1035

Closed

ravishanker mentioned this pull request Mar 16, 2023

Upgrade Gutenberg-Mobile to Android 13 wordpress-mobile/gutenberg-mobile#5556

Closed

13 tasks

Merge branch 'trunk' into update-compile-sdk-to-33

2785da1

ParaskP7 self-assigned this Mar 21, 2023

ParaskP7 approved these changes Mar 21, 2023

View reviewed changes

irfano merged commit 499459d into trunk Mar 21, 2023

irfano deleted the update-compile-sdk-to-33 branch March 21, 2023 21:38

ParaskP7 mentioned this pull request May 10, 2023

Dependency Updates wordpress-mobile/WordPress-Android#17551

Closed

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update compile sdk to 33 #1037

Update compile sdk to 33 #1037

irfano commented Mar 13, 2023 •

edited

Loading

irfano commented Mar 13, 2023

khaykov commented Mar 13, 2023

irfano commented Mar 14, 2023

ParaskP7 left a comment

ParaskP7 Mar 21, 2023

irfano Mar 21, 2023

ParaskP7 Mar 21, 2023

Update compile sdk to 33 #1037

Update compile sdk to 33 #1037

Conversation

irfano commented Mar 13, 2023 • edited Loading

Fix

Test

Review

irfano commented Mar 13, 2023

khaykov commented Mar 13, 2023

irfano commented Mar 14, 2023

ParaskP7 left a comment

Choose a reason for hiding this comment

ParaskP7 Mar 21, 2023

Choose a reason for hiding this comment

irfano Mar 21, 2023

Choose a reason for hiding this comment

ParaskP7 Mar 21, 2023

Choose a reason for hiding this comment

irfano commented Mar 13, 2023 •

edited

Loading