Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set all nav title is center for android,successful running! #54

Closed
wants to merge 3 commits into from

Conversation

mingxia
Copy link
Contributor

@mingxia mingxia commented Sep 2, 2015

It looks much more comfortable.

@mingxia mingxia changed the title Set all nav title is center,successful running! Set all nav title is center for android,successful running! Sep 2, 2015
@shprink
Copy link
Collaborator

shprink commented Sep 2, 2015

This can be set via the ionic config. I would rather expose this via config.json if people want to overwrite the ionic behavior.

http://ionicframework.com/docs/api/provider/$ionicConfigProvider/

navBar.alignTitle(value)

@shprink shprink closed this Sep 2, 2015
@mingxia
Copy link
Contributor Author

mingxia commented Sep 3, 2015

Just seen, it is a better solution. However, I still think the best will be centered as the default configuration, this would facilitate a lot of people. Let android, ios style unification

@shprink
Copy link
Collaborator

shprink commented Sep 3, 2015

I want to keep ionic default configuration. They follow device standards so I do not want to change that. I am gonna give developers access to ionic configuration so they can change whatever they want from config.json

@shprink
Copy link
Collaborator

shprink commented Sep 3, 2015

@mingxia I created #55 to do that.

If you wish to try please let me know. Otherwise I will do it soon

@mingxia
Copy link
Contributor Author

mingxia commented Sep 3, 2015

I am busy something else, you do it. In addition “backButton.text(value) ” default is back, can according to language change?

@shprink
Copy link
Collaborator

shprink commented Sep 3, 2015

Good thought! I am adding this to the ticket thanks.

@mingxia
Copy link
Contributor Author

mingxia commented Sep 3, 2015

I see what you mean, it is very necessary to keep the standard of the state, but at the same time in the config.json provides a customizable interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants