[레거시 코드 리팩터링 - 4단계] 망고(고재철) 미션 제출합니다. #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choi-JJunho
requested changes
Oct 29, 2023
kitchenpos-api/build.gradle
Outdated
Comment on lines
1
to
6
| plugins { | ||
| id("java") | ||
| } | ||
|
|
||
| group = "kitchenpos" | ||
| version = "0.0.1-SNAPSHOT" |
There was a problem hiding this comment.
가장 최상위 디렉터리에 존재하는 build.gradle에 선언되어있는 내용이므로 생략해도 될 것 같아요!
kitchenpos-core/build.gradle
Outdated
Comment on lines
1
to
6
| plugins { | ||
| id("java") | ||
| } | ||
|
|
||
| group = "kitchenpos" | ||
| version = "0.0.1-SNAPSHOT" |
There was a problem hiding this comment.
가장 최상위 디렉터리에 존재하는 build.gradle에 선언되어있는 내용이므로 생략해도 될 것 같아요!
ditto
| @@ -56,7 +56,7 @@ class 테이블_단체_지정 { | |||
| final var request = TableGroupFixture.단체지정요청_생성(Collections.singletonList(savedOrderTable)); | |||
|
|
|||
| // when & then | |||
| assertThatThrownBy(() -> tableGroupService.create(request)) | |||
| Assertions.assertThatThrownBy(() -> tableGroupService.create(request)) | |||
There was a problem hiding this comment.
오잉?! 패키지를 옮기면서 static import들이 모조리 풀려버린 것 같네요 ㅠㅠㅜ
Choi-JJunho
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 주노!
드디어 마지막 미션 마지막 단계네요..
멀티 모듈 처음 적용해보는데 이상한 곳에서 터지고 생각보다 시간이 걸렸네요 🥲
컨텍스트 별로 분리할까 생각하다가 그래도 처음 해보는 거고 시간이 많지 않아서, 힌트에 나와있는 jojoldu님 블로그 참고해서 core랑 api로 나눠보았습니다!
(블로그에는 api(db와 상호작용), web(사용자와 상호작용)으로 나와있는데 core(db와 상호작용), api(사용자와 상호작용)가 더 어울리는 것 같아서 바꿨습니다 ^^)
마지막까지 부족한 코드지만 잘 부탁드립니다..!
지금까지 주노가 있어서 우테코 10개월이 즐겁고 편했네요. 항상 이것 저것 많은 도움 줘서 고마워용
나중에 술 한 번 살게요 :)