[레거시 코드 리팩터링 - 4단계] 에어(김준서) 미션 제출합니다. #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 크로플ㅎㅎ...
step3 머지해주시자 마자 step4를 보내서 죄송합니다.. 26일까지 끝내보려고 미리 다른 브랜치에서 작업해놨어서 cherry pick만 했네요ㅎㅎ..
step4를 진행하면서 '어떤 기준으로 모듈을 나눠야하지?'라는 고민을 많이 했어요.
아래 영상과 블로그를 참고하면서 진행해봤습니다.
결국 지금은 아래와 같이 step3에서 분리했던 단위 별로 모듈을 분리하고(다중 도메인 모듈), 유저의 요청을 처리하는 api 서버를 따로 모듈로 분리해봤어요. api 서버에서 도메인 모듈들을 의존하도록 했습니다.
처음 해보는 거라 좋은 설계인지 감이 잘 안오네요. 코드 자체는 바뀐게 없고 모듈 분리만 했습니다!
남은 기간 화이팅!!