refactor: finally 블록 예외 시 로깅 처리

woowacourse · Oct 15, 2023 · 697db42 · 697db42
1 parent c58d27d
commit 697db42
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/app/src/main/java/com/techcourse/support/jdbc/init/DatabasePopulatorUtils.java b/app/src/main/java/com/techcourse/support/jdbc/init/DatabasePopulatorUtils.java
@@ -32,13 +32,17 @@ public static void execute(final DataSource dataSource) {
                 if (statement != null) {
                     statement.close();
                 }
-            } catch (SQLException ignored) {}
+            } catch (SQLException e) {
+                log.warn(String.valueOf(e));
+            }
 
             try {
                 if (connection != null) {
                     connection.close();
                 }
-            } catch (SQLException ignored) {}
+            } catch (SQLException e) {
+                log.warn(String.valueOf(e));
+            }
         }
     }
 

diff --git a/jdbc/src/main/java/org/springframework/transaction/support/TransactionManager.java b/jdbc/src/main/java/org/springframework/transaction/support/TransactionManager.java
@@ -4,12 +4,16 @@
 import java.sql.SQLException;
 import java.util.function.Supplier;
 import javax.sql.DataSource;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.dao.DataAccessException;
 import org.springframework.jdbc.datasource.DataSourceUtils;
 import org.springframework.transaction.TransactionException;
 
 public class TransactionManager {
 
+    private static final Logger log = LoggerFactory.getLogger(TransactionManager.class);
+
     private final DataSource dataSource;
 
     public TransactionManager(DataSource dataSource) {
@@ -75,7 +79,7 @@ private void release(Connection connection) {
             DataSourceUtils.releaseConnection(connection, dataSource);
             TransactionSynchronizationManager.unbindResource(dataSource);
         } catch (Exception e) {
-            throw new TransactionException(e);
+            log.warn(String.valueOf(e));
         }
     }