Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

서버 배포 스크립트 작성 #26

Merged
merged 2 commits into from
Jul 17, 2023
Merged

서버 배포 스크립트 작성 #26

merged 2 commits into from
Jul 17, 2023

Conversation

wonyongChoi05
Copy link
Collaborator

📄 Summary

#23

🙋🏻 More

@wonyongChoi05 wonyongChoi05 changed the base branch from main to develop July 17, 2023 05:41
@iamjooon2
Copy link
Collaborator

메인브랜치 실화인가요?

kyY00n
kyY00n approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@kyY00n kyY00n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

베베 첫 PR을 축하합니다!

backend/deploy.sh Show resolved Hide resolved
backend/deploy.sh Show resolved Hide resolved
iamjooon2
iamjooon2 reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@iamjooon2 iamjooon2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배포 스크립트 작성하는 김에 Graceful Shutdown 도 같이 적용하면 좋을 것 같습니다!

backend/deploy.sh Outdated
echo "> 현재 구동중인 애플리케이션이 없으므로 종료하지 않습니다."
else
echo "> kill -9 $CURRENT_PID"
sudo kill -9 $CURRENT_PID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sudo kill -9 $CURRENT_PID
sudo kill -15 $CURRENT_PID

강제종료 보다는 정상종료로 안전하게 가는 것은 어떤가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋습니다!

@wonyongChoi05 wonyongChoi05 merged commit 5302f05 into develop Jul 17, 2023
@wonyongChoi05 wonyongChoi05 deleted the feature/#23 branch July 17, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyY00n kyY00n kyY00n approved these changes

@iamjooon2 iamjooon2 iamjooon2 approved these changes

Assignees

@parkmuhyeun parkmuhyeun

@wonyongChoi05 wonyongChoi05

Labels
🕋 Backend ✨ Feature 🌍 Infrastructure
Projects
2023-zipgo
Archived in project
Milestone
프로젝트 초기 셋팅
Development

Successfully merging this pull request may close these issues.
4 participants
@wonyongChoi05 @iamjooon2 @kyY00n @parkmuhyeun