Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] refactor: RankingProduct -> ProductRanking 으로 변경 #73

Merged
merged 3 commits into from
Jul 19, 2023
Merged

[FE] refactor: RankingProduct -> ProductRanking 으로 변경 #73

merged 3 commits into from
Jul 19, 2023

Conversation

hae-on
Copy link
Collaborator

@hae-on hae-on commented Jul 18, 2023

Issue

✨ 구현한 기능

  • RankingProduct -> ProductRanking 으로 변경하였습니다.
  • bottom sheet content가 다시 살아나 삭제하였습니다.
  • rankingReview.json -> reviewRanking.json으로 변경하였습니다.

📢 논의하고 싶은 내용

x

🎸 기타

x

⏰ 일정

  • 추정 시간 : 30분
  • 걸린 시간 : 30분

@hae-on hae-on requested review from xodms0309 and Leejin-Yang July 18, 2023 08:40
@hae-on hae-on self-assigned this Jul 18, 2023
Leejin-Yang
Leejin-Yang approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@Leejin-Yang Leejin-Yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

xodms0309
xodms0309 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hae-on hae-on merged commit 9819090 into develop Jul 19, 2023
@hae-on hae-on deleted the feat/issue-71 branch July 19, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xodms0309 xodms0309 xodms0309 approved these changes

@Leejin-Yang Leejin-Yang Leejin-Yang approved these changes

Assignees

@hae-on hae-on

Labels
🔑 FE 🔧 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] RankingProduct -> ProductRanking 으로 변경
3 participants
@hae-on @xodms0309 @Leejin-Yang