Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix: 리뷰 작성 시 리뷰 탭 이동 및 유지 #623

Merged
merged 13 commits into from
Sep 14, 2023

Conversation

Leejin-Yang
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 리뷰 작성 시 리뷰 탭 이동 및 유지
  • 선택된 탭 메뉴 상태를 인덱스로 수정

📢 논의하고 싶은 내용

  • 이전 코드는 리뷰가 작성되면 리뷰 전체 수가 변경되어서 첫번째 배열요소가 달라집니다.
  • 그래서 인지를 하지 못해 꿀조합 탭을 보여주고 select 된 값이 없어 selected tab menu가 스타일이 안 먹은 것이었습니다.
  • 그래서 인덱스로 바꾸고 커스텀 훅을 작성했는데 확인해주세요!!

🎸 기타

  • 특이 사항이 있으면 작성합니다.

⏰ 일정

  • 추정 시간 : 2시간
  • 걸린 시간 : 3시간

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Unit Test Results

8 tests   8 ✔️  9s ⏱️
3 suites  0 💤
1 files    0

Results for commit 5703c2b.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 하나만 확인해주쇼잉

Comment on lines 14 to 16
const setFirstTabMenu = () => {
setSelectedTabMenu(INIT_TAB_INDEX);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initTabMenu 같은 네이밍은 어때요? 뭔가 setState랑 헷갈려요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예압 좋네요~ 감사합니다!

Copy link
Collaborator

@hae-on hae-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 수고했슴당

Copy link
Collaborator

@xodms0309 xodms0309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leejin-Yang Leejin-Yang merged commit e449de2 into develop Sep 14, 2023
@Leejin-Yang Leejin-Yang deleted the feat/issue-612 branch September 14, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 완료
Development

Successfully merging this pull request may close these issues.

[FE] 리뷰 작성 시 탭 이동 수정
3 participants