[FE] feat: ProductItem, ProductList 컴포넌트 추가 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xodms0309
requested changes
Jul 16, 2023
| <Text size="lg" weight="bold"> | ||
| {name} | ||
| </Text> | ||
| <Text color={theme.textColors.info}>{price.toLocaleString('ko-KR')}원</Text> |
There was a problem hiding this comment.
시안을 보면 가격이 사이즈가 xs 여야 할 것 같아요
There was a problem hiding this comment.
xs 사이즈 너무 작아보여서 일단 뒀습니다..
| @@ -0,0 +1,29 @@ | |||
| import productImage from './mock_img.jpg'; | |||
There was a problem hiding this comment.
아직 msw 안 했어도 이 파일은 mocks/data 아래에 있어도 될 것 같아요
Comment on lines
3
to
10
| export interface Product { | ||
| id: number; | ||
| name: string; | ||
| price: number; | ||
| image: string; | ||
| averageRating: number; | ||
| reviewCount: number; | ||
| } |
There was a problem hiding this comment.
이 타입도 types아래에 product.ts 이런식으로 만들면 좋을 것 같아요
Comment on lines
+10
to
+11
| export default meta; | ||
| type Story = StoryObj<typeof ProductList>; |
hae-on
approved these changes
Jul 17, 2023
|
@xodms0309 @hae-on
확인해주세요~ |
xodms0309
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타