[FE] feat: 카테고리에 따른 태그 색상 변경 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leejin-Yang
reviewed
Aug 9, 2023
| @@ -21,6 +25,7 @@ const ReviewTagItem = ({ id, name, isSelected }: ReviewTagItemProps) => { | |||
| <Button type="button" weight="bold" variant="transparent" onClick={handleReviewTag}> | |||
| <TagBadge | |||
| isSelected={isSelected} | |||
| tagColor={tagColor} | |||
There was a problem hiding this comment.
variant를 받아서 스타일드에서 스타일로 넣어두는건 어떤가요?
디자인 시스템에서 했던 느낌으로다가요
const tagColorStyles = {
TASTE: css`
border: ...
color: ...
...
}
아마 이런 느낌??
Leejin-Yang
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
카테고리에 따라 태그 색상을 변경할 수 있도록 하였습니다.
📢 논의하고 싶은 내용
x
🎸 기타
x
⏰ 일정