Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] feat: 리뷰 작성 기능 구현 #24

Merged
merged 24 commits into from
Jul 17, 2023
Merged

[BE] feat: 리뷰 작성 기능 구현 #24

merged 24 commits into from
Jul 17, 2023

Conversation

wugawuga
Copy link
Collaborator

Issue

✨ 구현한 기능

  • 해당 상품에 대한 리뷰 작성 기능을 구현했습니다.

📢 논의하고 싶은 내용

  • x

🎸 기타

  • x

@wugawuga wugawuga added this to the 마일스톤 1주차 milestone Jul 14, 2023
@wugawuga wugawuga self-assigned this Jul 14, 2023
70825
70825 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@70825 70825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정할만한 내용 코멘트 남겼어요~!!
고생하셨습니다 👍

backend/src/main/java/com/funeat/member/domain/Member.java Show resolved Hide resolved
backend/src/main/java/com/funeat/review/application/ReviewService.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/review/domain/Review.java Outdated Show resolved Hide resolved
hanueleee
hanueleee approved these changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@hanueleee hanueleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

복잡한 리뷰 작성 기능 구현하느라 수고많았습니다 우가~~👍

backend/src/main/java/com/funeat/review/application/ReviewService.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/review/application/ReviewService.java Outdated Show resolved Hide resolved
Go-Jaecheol
Go-Jaecheol approved these changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@Go-Jaecheol Go-Jaecheol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 설명 시간에 얘기한 것들 말고는 크게 얘기할 게 없네요.
고생하셨습니다~~

backend/src/main/java/com/funeat/review/presentation/dto/ReviewCreateRequest.java Outdated Show resolved Hide resolved
backend/src/main/java/com/funeat/review/application/ReviewService.java Outdated Show resolved Hide resolved
wugawuga added 9 commits July 15, 2023 21:49
@wugawuga
test: TagRepository 커스텀 메소드 테스트
be0fbbb
@wugawuga
refactor: 리뷰서비스 테스트 조건 수정
7b959f3
@wugawuga
feat: 리뷰 등록시 이미지 저장 경로 분리, 환경변수 설정 추가
10c4a12
@wugawuga
feat: 이미지 업로드 시 빈파일 생성 이슈 해결
1e1642f 
- dev, test 분리하여 test 시에는 임시 폴더, 파일생성 후 삭제로직 구현
@wugawuga
style: 코드 컨벤션따라 수정
1ffb680
@wugawuga
style: 테스트 코드 컨벤션따라 수정
b7a9c02
@wugawuga
refactor: beforeEach deleteAll 로 초기화 후 테스트 시작
9a025fb
@wugawuga
refactor: cascade 옵션 삭제, review 편의메소드 추가
6308d89 
- 정적팩토리 메소드로 가독성 높임
@wugawuga
refactor: Tag 에서 ReviewTag 양방향 매핑 삭제
36bab6f 
- Tag 를 조회해 리뷰 접근 가능성 있을 때 추가 예정
@wugawuga wugawuga merged commit 3615fe0 into develop Jul 17, 2023
@hanueleee hanueleee removed this from the 마일스톤 1주차 milestone Jul 18, 2023
@70825 70825 deleted the feat/issue-17 branch July 24, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Go-Jaecheol Go-Jaecheol Go-Jaecheol approved these changes

@70825 70825 70825 approved these changes

@hanueleee hanueleee hanueleee approved these changes

Assignees

@wugawuga wugawuga

Labels
🔒 BE ✨ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] 상품에 대한 리뷰 작성 기능
4 participants
@wugawuga @Go-Jaecheol @70825 @hanueleee