This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Add support for AtlasBuildTools integration when added via UPM #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== This patch adds support to add the test build setup when the package `AtlasBuildTools` is added via upm as package `com.wooga.atlas-build-tools`. There is a slight issue with this implementation as it evaluates the `projectManifestFile` property from the unity extension. The whole generation should be lazy here but that would make the setup more complicated and the test setup would need to be completely rewritten. I opted for this solution since the plugin is opinionated anyways, and we usually can't override the location for the manifest file anyways. Changes ======= * ![ADD] support for AtlasBuildTools integraton when added via UPM
Azurelol
approved these changes
Jan 24, 2023
|
@Azurelol I think the setup is ok enough. I would actually change the whole implementation so these tests are no longer possible as Unit tests. I will merge as is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch adds support to add the test build setup when the package
AtlasBuildToolsis added via upm as packagecom.wooga.atlas-build-tools.There is a slight issue with this implementation as it evaluates the
projectManifestFileproperty from the unity extension. The whole generation should be lazy here but that would make the setup more complicated and the test setup would need to be completely rewritten.I opted for this solution since the plugin is opinionated anyways, and we usually can't override the location for the manifest file anyways.
Changes