This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Fix publish with non set upm package directory #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== The last release added a small issue with the way the publish setup. The configuration for the upmPack and creation depends on the `packageDir` being set. The problem is that a publications should not be conditional. Either they work or not. In our case here the publish needs to be conditional. So I made the decision to only add the dependency to the main `publish` task if all the configuration settings are available. The general `artifactoryPublish` would still fail. Changes ======= * ![FIX] publish with non set upm package directory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last release added a small issue with the way the publish setup. The configuration for the upmPack and creation depends on the
packageDirbeing set. The problem is that a publications should not be conditional. Either they work or not. In our case here the publish needs to be conditional. So I made the decision to only add the dependency to the mainpublishtask if all the configuration settings are available. The generalartifactoryPublishwould still fail.Changes