Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Improve inputs #60

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Improve inputs #60

merged 2 commits into from
Apr 14, 2023

Conversation

Joaquimmnetto
Copy link
Contributor

@Joaquimmnetto Joaquimmnetto commented Apr 5, 2023

Description

Several small refactors and improvements to input-related classes.

  • Renames VersionCodeScheme to VersionCodeSchemes to keep consistency with the VersionSchemes name.
  • Gives preference to Property<T> instead of Provider<T> for input extension types
  • Adds prefix to VersionPluginConventions and reformat the class to be more similar to whats in the newer plugins.
  • Moves out extension convention setup from DefaultVersionPluginExtension constructor.

Based on #59 , please merge that first.

Changes

  • CHANGE All extension properties now are Property<T> instead of Provider<T>
  • ADD prefix property now can be set through environment or gradle properties.

@Joaquimmnetto Joaquimmnetto self-assigned this Apr 5, 2023
@Joaquimmnetto Joaquimmnetto changed the base branch from master to add/version-prefix April 5, 2023 10:14
@Joaquimmnetto Joaquimmnetto changed the base branch from add/version-prefix to TODOs April 5, 2023 10:14
@Joaquimmnetto Joaquimmnetto force-pushed the improve/inputs branch 3 times, most recently from bd596de to 87177e0 Compare April 5, 2023 10:26
@Joaquimmnetto Joaquimmnetto force-pushed the improve/inputs branch 3 times, most recently from ec40a42 to 97121e3 Compare April 11, 2023 13:52
@Joaquimmnetto Joaquimmnetto marked this pull request as ready for review April 12, 2023 09:18
Copy link
Member

@Larusso Larusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see that you addressed some comments I made in the Original PR #58 Would it be possible to combine these PRs? If not lets see how we best merge the changes

@Joaquimmnetto Joaquimmnetto changed the base branch from TODOs to release/3.x April 14, 2023 13:43
@Joaquimmnetto Joaquimmnetto merged commit 990f53f into release/3.x Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants