This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Remove coveralls reporting [ATLAS-749] #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description =========== Because of security issues reported for the coveralls gradle plugin I decided to remove the feature during build. It is not enough to just stop sending reports via jenkins. We also need to update to `net.wooga.plugins` > `4.0.0` because this version removes the dependency. I remove the coveralls token in the Jenkinsfile so our base pipeline won't try to call the coveralls task on the gradle project. Changes ======= * ![UPDATE] `net.wooga.plugins` to version `4.0.0` to remove coveralls dependency * ![REMOVE] coveralls token in Jenkinsfile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of security issues reported for the coveralls gradle plugin I decided to remove the feature during build. It is not enough to just stop sending reports via jenkins. We also need to update to
net.wooga.plugins>4.0.0because this version removes the dependency.I remove the coveralls token in the Jenkinsfile so our base pipeline won't try to call the coveralls task on the gradle project.
Changes
net.wooga.pluginsto version4.0.0to remove coveralls dependency