Add discrete install provisioning profile task #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larusso
force-pushed
the
add/install_provisioning_profile_task
branch
3 times, most recently
from
5bca434
to
66bee73
Compare
Description =========== We use fastlane at the moment to import provisional and install provisioning profiles. The install part is indirect because fastlane itself does it for us under the hood. This worked for us very well over the years. But there is no real chance to install profiles in any other way. Hence a discrete install profile task. To be able to install provisioning profiles one needs to be able to read the UUID out of the included meta data. The reason is that all profiles are stored on the system with the UUID as the file name. I created a new helper class + test mock class to read provisioning profiles and fetch the metadata from them. A profile consists of 3 pieces: 1. A header (some bytes long) I have no information what information is stored there 2. The meta data in plist format 3. a series of certificates (unknown format) We are mainly interested in the meta data. I removed the import provisioning profiles task from the direct task dependency list. Instead the new task `installProvisioningProfiles` will be used in it's place. This new task will have a dependency (_indirect_) to the `importProvisioningProfiles` task. This means that one could reconfigure the `importProvisioningProfiles` tasks and skip the fastlane backed task `importProvisioningProfiles` all together. This is needed for out new alternative flow where we store the profiles in the aws secrets manager. Changes ======= * ![ADD] `InstallProvisioningProfiles` task type
Larusso
force-pushed
the
add/install_provisioning_profile_task
branch
from
66bee73
to
cf1445b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use fastlane at the moment to import provisional and install provisioning profiles. The install part is indirect because fastlane itself does it for us under the hood. This worked for us very well over the years. But there is no real chance to install profiles in any other way. Hence a discrete install profile task.
To be able to install provisioning profiles one needs to be able to read the UUID out of the included meta data. The reason is that all profiles are stored on the system with the UUID as the file name. I created a new helper class + test mock class to read provisioning profiles and fetch the metadata from them. A profile consists of 3 pieces:
We are mainly interested in the meta data.
I removed the import provisioning profiles task from the direct task dependency list. Instead the new task
installProvisioningProfileswill be used in it's place. This new task will have a dependency (indirect) to theimportProvisioningProfilestask. This means that one could reconfigure theimportProvisioningProfilestasks and skip the fastlane backed taskimportProvisioningProfilesall together.This is needed for out new alternative flow where we store the profiles in the aws secrets manager.
Changes
InstallProvisioningProfilestask type