Squash Sonic USDC.e #136
Squash Sonic USDC.e #136
Conversation
…are/collateral-extension
…tware/comet into woof-software/collateral-extension
…xtension-audit-fix Audit fixes to collateral extension
…software/comet into woof-software/deploy-sonic-usdc-market
…software/comet into woof-software/deploy-sonic-usdc-market
…of-software/deploy-sonic-usdc-market
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| constructor(address l2Router_) { | ||
| l2Router = l2Router_; | ||
| } |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
| constructor(address l2Router_) { | ||
| l2Router = l2Router_; | ||
| } |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.non-payable-constructor Note
| } | ||
|
|
||
| function toAddress(bytes memory data) public pure returns (address addr) { | ||
| require(data.length >= 20, "Invalid data length"); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note
| function initialize(address _timelock, address _bridge) public { | ||
| require(timelock == address(0), "already initialized"); | ||
| timelock = _timelock; | ||
| bridge = _bridge; | ||
| } |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.lack-of-revert-alreadyinitialized Error
| mapping(uint256 => ClaimData) public claims; | ||
|
|
||
| function initialize(address _timelock, address _bridge) public { | ||
| require(timelock == address(0), "already initialized"); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note
| (bool success, bytes memory returnData) = targets[i].call{value: values[i]}(callDatas[i]); | ||
| if (!success) { | ||
| // revert with the original error message from the call | ||
| if (returnData.length > 0) { |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.array-length-outside-loop Note
| revert(add(32, returnData), returndata_size) | ||
| } | ||
| } else { | ||
| revert("Delegator: call failed"); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note
| constructor(address l2Router_) { | ||
| l2Router = l2Router_; | ||
| } |
Check warning
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.missing-constructor-sanity-checks Warning
| constructor(address l2Router_) { | ||
| l2Router = l2Router_; | ||
| } |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.non-payable-constructor Note
| } | ||
|
|
||
| function toAddress(bytes memory data) public pure returns (address addr) { | ||
| require(data.length >= 20, "Invalid data length"); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note
No description provided.