Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid type for getTx #221

Closed
sharifzadesina opened this issue Jul 17, 2024 · 1 comment
Closed

Invalid type for getTx #221

sharifzadesina opened this issue Jul 17, 2024 · 1 comment

Comments

@sharifzadesina
Copy link

The description of MoneroWalletFull.getTx says "the identified transaction or undefined if not found", but the return type in TS is Promise<MoneroTxWallet> which does not include undefined.

This causes unexpected behavior.
woodser added a commit that referenced this issue Aug 15, 2024
@woodser
return promise includes undefined when applicable #221
bfe0ab9
woodser added a commit that referenced this issue Aug 15, 2024
@woodser
return promise includes undefined when applicable #221
857b14d
woodser added a commit that referenced this issue Aug 15, 2024
@woodser
return promise includes undefined when applicable #214, #221
c9cc223
woodser added a commit that referenced this issue Aug 16, 2024
@woodser
return promise includes undefined when applicable #214, #221
76ad4f6
woodser added a commit that referenced this issue Aug 16, 2024
@woodser
return promise includes undefined when applicable #214, #221
db17989
@woodser
Copy link
Owner

woodser commented Aug 22, 2024

This issue is fixed in the latest 0.10.1 release. Thanks!

@woodser woodser closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@woodser @sharifzadesina