Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying dind container in values #750

Merged
merged 3 commits into from
Feb 6, 2022
Merged

Allow specifying dind container in values #750

merged 3 commits into from
Feb 6, 2022

Conversation

fpiesche
Copy link
Contributor

@fpiesche fpiesche commented Feb 6, 2022

This allows:

  • resource spec for the dind container different from the main agent
  • environment variables for the dind container can also be specified in values, e.g. to change the default driver if one so wishes
  • crucially: specifying a different dind image

I'm finding myself needing to use an unofficial image instead of the standard docker one as the official ones have been broken on armv7 (e.g. Raspberry Pi 2, or any Pi3/Pi4 running a 32bit operating system) since some time in the 0.19 series.

@6543 6543 added enhancement improve existing features chart labels Feb 6, 2022
@6543 6543 added this to the 0.15.0 milestone Feb 6, 2022
@6543
Copy link
Member

6543 commented Feb 6, 2022

helm lint fail :/ @fpiesche

@6543 6543 merged commit dbd048c into woodpecker-ci:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants