Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter revive #554

Merged
merged 8 commits into from
Dec 1, 2021
Merged

Add linter revive #554

merged 8 commits into from
Dec 1, 2021

Conversation

lukashass
Copy link
Member

Part of #435

Summary of fixes

  • remove underscores from variable names (replace trailing with leading underscore to avoid shadowing)
  • capitalize e.g. URL, HTTP, ID in variable names
  • remove else after return
  • comment for blank imports
  • remove trailing punctuation in error messages
  • make error the last return value

@lukashass lukashass changed the title Linter revive Add linter revive Nov 28, 2021
@6543 6543 added this to the 0.15.0 milestone Nov 30, 2021
@6543 6543 added the refactor delete or replace old code label Nov 30, 2021
6543
6543 reviewed Nov 30, 2021
View reviewed changes
server/shared/procBuilder.go Outdated Show resolved Hide resolved
@6543 6543 merged commit 680d003 into woodpecker-ci:master Dec 1, 2021
@lukashass lukashass deleted the linter-revive branch December 1, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lukashass @6543