-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix repo access (#476) #477
Fix repo access (#476) #477
Conversation
* fix repo access * fix permission syncing
test failed I have to ajust it to work with v0.14 :/ |
@6543 this caused the github user to run out of api calls (request limits) the webhooks started to receive 403 from github, and reported back 404. Any chance we can make the perms sync less aggressive? |
I'd like to make that sync on demand later ... but this wont be backported as it would be twice the amount of work. meanwhile I created an issue for it: #485 for your big org best would be to pin to the old version v0.14.1 until v0.15.0 is here i guess sorry for the inconvenience - if you have a idear how to fix it for v0.14 just tell :) |
hey @6543 no worries. We're in a delicate situation, as v0.14.1 doesn't contain the fixes for double wildcard nor for depends_on, and v0.14.2 lacks a frontend (see the discord conversation about index.html panicking). If this change (fetch perms per user per repo) is part of v0.15.0, then we will not be able to upgrade to that either. I would suggest we make fetching permissions configurable for now (I can try a PR). for large orgs with flat permissions (everyone has rw access to everything, we only use branch protection) the fetching of perms per user/per repo is not needed. |
@alexef the missing frontend should be fixed now ... what you propose is a workaround but I'm happy to merge it into v0.14 branch untill properly solved. |
ok let's keep chating via discord or matrix :) |
Backport #476
fix repo access
fix permission syncing