Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify CLI bin name #4673

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Unify CLI bin name #4673

merged 1 commit into from
Jan 6, 2025

Conversation

qwerty287
Copy link
Contributor

No description provided.

@qwerty287 qwerty287 added breaking will break existing installations if no manual action happens build CI pipeline related labels Jan 6, 2025
@qwerty287 qwerty287 requested a review from a team January 6, 2025 07:06
@pat-s
Copy link
Contributor

pat-s commented Jan 6, 2025

Rethinking this again, a cli binary with a -cli suffix is somewhat uncommon. Should we maybe rename everything to woodpecker instead?

@qwerty287
Copy link
Contributor Author

I think that would create more confusion.
If somebody wants to start with a server and you have three files, two suffixed with server/agent and one without suffix, there might be a lot of people trying the one without suffix first.
I'd call it woodpecker-cli and if that doesn't work, just set an alias in your shell config…

@pat-s
Copy link
Contributor

pat-s commented Jan 6, 2025

Alright, convinced.

@pat-s pat-s enabled auto-merge (squash) January 6, 2025 08:46
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Jan 6, 2025 •
edited
Loading

Deployment of preview was torn down

@pat-s pat-s merged commit 0eccf12 into woodpecker-ci:main Jan 6, 2025
7 checks passed
@qwerty287 qwerty287 deleted the bin-name branch January 6, 2025 08:52
@woodpecker-bot woodpecker-bot mentioned this pull request Jan 6, 2025
Merged
1 task
@BrewTestBot BrewTestBot mentioned this pull request Jan 18, 2025
Merged
@emilylange emilylange mentioned this pull request Jan 21, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens build CI pipeline related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qwerty287 @pat-s @woodpecker-bot @xoxys