Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addon nil values #4666

Merged
merged 3 commits into from
Jan 5, 2025
Merged

Fix addon nil values #4666

merged 3 commits into from
Jan 5, 2025

Conversation

qwerty287
Copy link
Contributor

closes #4662

@qwerty287 qwerty287 added bug Something isn't working addon labels Jan 5, 2025
@qwerty287 qwerty287 requested a review from a team January 5, 2025 09:46
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.16%. Comparing base (f30fc29) to head (1ef3a12).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
server/forge/addon/args.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4666      +/-   ##
==========================================
- Coverage   28.17%   28.16%   -0.02%     
==========================================
  Files         398      398              
  Lines       28193    28205      +12     
==========================================
  Hits         7944     7944              
- Misses      19543    19555      +12     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit ba68b44 into woodpecker-ci:main Jan 5, 2025
7 of 9 checks passed
@qwerty287 qwerty287 deleted the fix-addon branch January 5, 2025 11:45
@woodpecker-bot
Copy link
Contributor

@woodpecker-bot woodpecker-bot mentioned this pull request Jan 5, 2025
1 task
pat-s pushed a commit to pat-s/woodpecker that referenced this pull request Jan 10, 2025
(cherry picked from commit ba68b44)
@pat-s
Copy link
Contributor

pat-s commented Jan 10, 2025

💚 All backports created successfully

Status Branch Result
release/v2.8

Questions ?

Please refer to the Backport tool documentation

pat-s added a commit that referenced this pull request Jan 10, 2025
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
@woodpecker-bot woodpecker-bot mentioned this pull request Jan 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants