-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rolling semver tags, remove latest
tag
#4600
Conversation
What will happen if we publish a release like 2.10.0? |
Oh dear, good point 🙈️ Changed it to the following CI_COMMIT_TAG="v2.10.0"
short_tag=${CI_COMMIT_TAG%.*}
echo "$short_tag"
v2.10 |
And what about 10.0.0? Same thing… |
And docs must get an update: https://woodpecker-ci.org/docs/administration/deployment-methods/docker-compose#docker-images |
Deployment of preview was torn down |
|
Sure but in this case users opted in to use this version on purpose and not by getting a background update due to a rolling tag.
Even though some/most might do, the "a major upgrade happened and everything broke" issues will never stop this way, also because people often don't set a tag at all and hence will get If you think about it, why should there ever be a tag crossing major version automatically? This will always result in a functional disaster. Admins have to adjust the config anyhow for a major upgrade, so arguing with "it reduces admin work" doesn't work. But it pro-actively prevents issues for admins and issues posted to the project. Does that make sense? |
That's reasonable, so may I know why Let me say it: Not everyone work for a big woodpecker with an admin, more people just leave an instance, write some script and never open it then. The only result of dropping I still want a stable tag use latest stable version, not CD one. It's fine it don't name |
A rolling tag across major versions would have likely meant that your CI stopped working silently for that period you didn't watch it. Not matter if large or small instance, removing it helped you just now to not break your pipelines. While not every major release might be "as breaking" as the previous ones were, I still think this is the best way forward. Once established, users know it and the scenario above won't occur. You are free to check for new upgrades whenever it fits. Until then, this policy protects you. An additional side effect is that people won't start with latest, protecting them from being unable to downgrade to the latest release due to DB schema migration. |
Not everyone work with a big woodpecker which can't break. Sure people shouldn't take I will move to |
fix #4597 fix #3131
latest
tag to avoid automatic major release upgrades