Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weakly decode backend options #4577

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

qwerty287
Copy link
Contributor

closes #4504

@qwerty287 qwerty287 added bug Something isn't working backend/kubernetes labels Dec 16, 2024
@qwerty287 qwerty287 requested a review from a team December 16, 2024 15:24
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.29%. Comparing base (b3c61fa) to head (88f1c1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4577   +/-   ##
=======================================
  Coverage   28.29%   28.29%           
=======================================
  Files         399      399           
  Lines       28164    28164           
=======================================
  Hits         7969     7969           
  Misses      19490    19490           
  Partials      705      705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-s pat-s merged commit 1ec785c into woodpecker-ci:main Dec 16, 2024
9 checks passed
@woodpecker-bot
Copy link
Contributor

@woodpecker-bot woodpecker-bot mentioned this pull request Dec 16, 2024
1 task
pat-s pushed a commit that referenced this pull request Dec 18, 2024
pat-s pushed a commit that referenced this pull request Dec 18, 2024
@qwerty287 qwerty287 deleted the weak-decode branch December 24, 2024 06:53
pat-s pushed a commit to pat-s/woodpecker that referenced this pull request Jan 10, 2025
(cherry picked from commit 1ec785c)

# Conflicts:
#	pipeline/backend/docker/backend_options.go
#	pipeline/backend/kubernetes/backend_options_test.go
@pat-s
Copy link
Contributor

pat-s commented Jan 10, 2025

💚 All backports created successfully

Status Branch Result
release/v2.8

Questions ?

Please refer to the Backport tool documentation

@xoxys
Copy link
Member

xoxys commented Jan 10, 2025

@pat-s can this message posting be disabled?

@pat-s
Copy link
Contributor

pat-s commented Jan 10, 2025

Ugh, hopefully (new tool).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/kubernetes bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes resources requests are ignored if numbers are used
4 participants