Expand docs around the deprecation of former secret syntax #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
zc-devs
reviewed
Dec 13, 2024
zc-devs
reviewed
Dec 13, 2024
Co-authored-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com>
zc-devs
reviewed
Dec 13, 2024
Co-authored-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com>
|
Thanks for the feedback, hopefully it resolved all the outstanding issues! |
|
Thanks, lgtm so far, but can you add that to the current docs as well (except the deprecation warning)? That's in |
|
Will do, just one question: why would the deprecation warning not go into the current docs? as far as I can tell it’s already been deprecated (but not removed) in the current 2.8 version? 🤔 |
|
current docs = 3.0 (for now). |
|
Ah, got it, I added it to the current docs w/o the deprecation warning! |
|
Deployment of preview was torn down |
qwerty287
reviewed
Dec 14, 2024
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
qwerty287
approved these changes
Dec 14, 2024
pat-s
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com> Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
pat-s
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com> Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been following along the discussion about the deprecation of the
secretssyntax with the planned removal for 3.x. I thought it would help to make people feel better informed/have an idea of what to do if the documentation is expanded a bit on that section.This is my attempt at this, but please feel free to expand/edit etc as needed!