Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: addon JSON pointers #4508

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fix: addon JSON pointers #4508

merged 3 commits into from
Dec 3, 2024

Conversation

jolheiser
Copy link
Member

This PR fixes some issues I ran into when creating an addon forge.

  • 28af9ba fixes some pointer dereference issues when unmarshaling JSON
  • 6211f04 moves a trace log outside an if-check. Not strictly necessary, but was slightly confusing before when debugging
  • 19936f6 makes a minor correction to the docs for the woodpecker module

Signed-off-by: jolheiser <git@jolheiser.com>
Signed-off-by: jolheiser <git@jolheiser.com>
Signed-off-by: jolheiser <git@jolheiser.com>
@jolheiser jolheiser added bug Something isn't working addon labels Dec 3, 2024
@woodpecker-bot
Copy link
Contributor

woodpecker-bot commented Dec 3, 2024

Deployment of preview was torn down

@qwerty287 qwerty287 merged commit 9f0611d into woodpecker-ci:main Dec 3, 2024
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 3, 2024
1 task
@jolheiser jolheiser deleted the addon branch December 3, 2024 19:06
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.18%. Comparing base (db45794) to head (19936f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/forge/addon/server.go 0.00% 7 Missing ⚠️
server/forge/addon/client.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4508      +/-   ##
==========================================
- Coverage   28.20%   28.18%   -0.02%     
==========================================
  Files         397      397              
  Lines       28158    28158              
==========================================
- Hits         7941     7936       -5     
- Misses      19512    19517       +5     
  Partials      705      705              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jolheiser added a commit to jolheiser/woodpecker that referenced this pull request Dec 4, 2024
Signed-off-by: jolheiser <git@jolheiser.com>
anbraten pushed a commit that referenced this pull request Dec 5, 2024
Signed-off-by: jolheiser <git@jolheiser.com>
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 5, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
pat-s pushed a commit that referenced this pull request Dec 18, 2024
Signed-off-by: jolheiser <git@jolheiser.com>
pat-s pushed a commit that referenced this pull request Dec 18, 2024
Signed-off-by: jolheiser <git@jolheiser.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants