-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter to list repository pipelines API #4416
Add filter to list repository pipelines API #4416
Conversation
We still need to filter on the client though to get reactive queries updating on changes coming from the sse stream. |
☝️ well yes but we also need it from the server as getting a random count of entry's even if there should exist more ... is bad e.g: https://ci.woodpecker-ci.org/repos/3780/branches/main -> somethimes it just displays 2 ... or 3 ... or some other random number |
Can you explain how server-side filtering help in this case? |
well you currently can not discover it if you dont have the link or are on the specific pull to retrive the link |
That was clear already, I still don't understand how server-side filtering will solve it. |
you have to query the server again and use that filter if you switch the pipeline list view to a different one |
If I have time I'll also update the frontend within this pull at some point |
Deployment of preview was torn down |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
==========================================
+ Coverage 28.21% 28.22% +0.01%
==========================================
Files 384 384
Lines 27833 27854 +21
==========================================
+ Hits 7852 7862 +10
- Misses 19292 19302 +10
- Partials 689 690 +1 ☔ View full report in Codecov by Sentry. |
we currently filter thing on the client side:
woodpecker/web/src/views/repo/RepoPullRequest.vue
Lines 27 to 40 in ce8cd02
this makes it possible to filter server side in an upcomming pull addressing the frontend