Move sqlite to woodpecker #438
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
anbraten
added
breaking
| return datastore.New( | ||
| c.String("driver"), | ||
| c.String("datasource"), | ||
| ) | ||
| } | ||
|
|
||
| // TODO Remove this once we are sure users aren't attempting to migrate from Drone to Woodpecker (possibly never) | ||
| func checkSqliteFile() error { | ||
| _, err := os.Stat("drone.sqlite") |
There was a problem hiding this comment.
This works only for binary installations. For docker installations the path set via WOODPECKER_DATABASE_DATASOURCE would be /var/lib/drone/woodpecker.sqlite. Maybe something like the suggestion in combination with removing if !c.IsSet("datasource") { would work. 🤔
| _, err := os.Stat("drone.sqlite") | |
| _, err := os.Stat(fmt.Sprintf("%s/drone.sqlite", filepath.Dir(c.String("datasource")))) |
| } | ||
| return err | ||
| } | ||
| return os.Rename("drone.sqlite", "woodpecker.sqlite") |
There was a problem hiding this comment.
Would probably need absolute paths version as well.
|
@anbraten I'm not sure about the docker paths, because they use env variables. imo this should only migrate if the user had made no other effort to change from default (that is, no env variable and no flag set) |
|
@jolheiser We currently have |
|
@anbraten I understand that it's the default, but only because we had it set that way. The current migration is a single check and then no-op after. I can change it, but it seems (imo) to be a slightly different case than an unused flag. |
|
Superseded by #494 |
Moves the sqlite file to woodpecker and attempts to migrate legacy drone sqlite files.
Note that if the CLI explicitly sets the datasource to
drone.sqlitethe migration will not run, as it is assumed the user has explicitly set it for a reason.