-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes documentation enhancements #4374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `settings` from the volume example, as it isn't needed, and throws an error in 2.7.3 Added a link to the Kubernetes PVC documentation, and a note about ReadWriteMany. Added details around setting up prometheus monitoring where both prometheus and woodpecker are in the same cluster. Included troubleshooting for prometheus failing to scrape metrics.
for more information, see https://pre-commit.ci
zc-devs
reviewed
Nov 13, 2024
Remove unnecessary note about settings being reserved for plugins. Move metrics configuration to deployment-methods/kubernetes.
for more information, see https://pre-commit.ci
zc-devs
reviewed
Nov 13, 2024
Co-authored-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com>
zc-devs
approved these changes
Nov 14, 2024
xoxys
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for expanding the documents, and sorry for being so picky 😇
docs/docs/30-administration/05-deployment-methods/20-kubernetes.md
Outdated
Show resolved
Hide resolved
docs/docs/30-administration/05-deployment-methods/20-kubernetes.md
Outdated
Show resolved
Hide resolved
docs/docs/30-administration/05-deployment-methods/20-kubernetes.md
Outdated
Show resolved
Hide resolved
docs/docs/30-administration/05-deployment-methods/20-kubernetes.md
Outdated
Show resolved
Hide resolved
docs/docs/30-administration/05-deployment-methods/20-kubernetes.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
xoxys
approved these changes
Nov 14, 2024
Deployment of preview was torn down |
CI failed ... |
c3e1a41
to
5d720ec
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated volume mount example to include both plugin and non-plugin based, as
settings
is incompatible withcommands
Added a link to the Kubernetes PVC documentation, and a note about ReadWriteMany.
Added details around setting up prometheus monitoring where both prometheus and woodpecker are in the same cluster.
Included troubleshooting for prometheus failing to scrape metrics.
Added links and examples for serviceAccountName configuration.