Deprecate secrets

[qwerty287]

Deprecate the secrets directive completely.

Closes #4015

[zc-devs]

replaces and closes #4218

Are you going to backport this PR?

Anyway, it is not a replacement, because it says "in 3.0 you can still use secrets, but in 4.0 it will be removed".
And in my PR I warn people "you use lower-cased secret, which currently upper-cased; it won't be in 3.0, therefore those steps will fail (very?) likely". Which technically is not changed pipeline syntax, but result is the same from user's point of view.

[qwerty287]

yeah ok removed that part again

[woodpecker-bot]

Deployment of preview was torn down

[codecov]

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 26.49%. Comparing base (ddd55ee) to head (1b89488).
Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
pipeline/frontend/yaml/linter/linter.go	7.69%	11 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4235      +/-   ##
==========================================
+ Coverage   26.47%   26.49%   +0.02%     
==========================================
  Files         376      377       +1     
  Lines       27465    27448      -17     
==========================================
+ Hits         7270     7271       +1     
+ Misses      19530    19511      -19     
- Partials      665      666       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[zc-devs]

Which technically is not changed pipeline syntax, but result is the same from user's point of view.

So, you could just remove secrets in 3.0 and warn in 2.7.
#3960 (comment)

[pat-s]

So, you could just remove secrets in 3.0 and warn in 2.7.

If you mean 2.7.2 etc: I think many users are sticking with 2.7.0 due to the breaking changes in 2.7.1+, so they won't ever see warnings in 2.7.2.

[qwerty287]

I'd also rather deprecate in v3 and remove in v4

[zc-devs]

If you mean 2.7.2

Yep

many users are sticking with 2.7.0 due to the breaking changes in 2.7.1+, so they won't ever see warnings in 2.7.2

Sad

I'd also rather deprecate in v3 and remove in v4

Sure, it was just thing to consider.