-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read long log lines from file storage correctly #4048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
reviewed
Aug 25, 2024
please dont forcepush if you can! it makes reviews harder and we squashmerge anyway ... |
lafriks
approved these changes
Aug 25, 2024
Deployment of preview was torn down |
thanks for not running at the dedicated pull :/ |
If you d'like to create a pull? 🙏 |
Sure, I'll have to think about proper messaging for a moment. |
6543
added a commit
that referenced
this pull request
Aug 25, 2024
because I got distracted by an unrelated CI error and thought the pull was ok :/ #4048 (comment)
6543
pushed a commit
to 6543-forks/woodpecker
that referenced
this pull request
Sep 5, 2024
6543
added a commit
to 6543-forks/woodpecker
that referenced
this pull request
Sep 5, 2024
because I got distracted by an unrelated CI error and thought the pull was ok :/ woodpecker-ci#4048 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log lines may contain up to 1 MB of text, but with default settings
bufio.Scanner
only reads lines up to 64k in length and fails on anything larger, rendering theScanner
unusable.As a result, the user won't see anything after the first very long line, including the line itself.
The output should be:
Instead, Woodpecker cuts everything after
3
:I tested this on jobs with up to 20 MBs of output (simply update
70k
with something like20M
).