Fix BB PR pipeline ref #3985
Merged
Fix BB PR pipeline ref #3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Jul 27, 2024
|
@6543 CI fails seems to not be related to the changes. Do you know what is happening? |
|
Tearing down https://woodpecker-ci-woodpecker-pr-3985.surge.sh |
6543
pushed a commit
to 6543-forks/woodpecker
that referenced
this pull request
Sep 5, 2024
j04n-f
added a commit
to j04n-f/woodpecker
that referenced
this pull request
Dec 10, 2024
|
@6543 Would this bugfix be possible to release as a patch to 2.8? |
|
@karatekaneen this fix already available (v2.8.1): |
|
@j04n-f Nice! Somehow I missed it when I read the release notes. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To set the
CI_COMMIT_PULL_REQUESTenvironment variable Woodpecker uses the following regexp:woodpecker/pipeline/frontend/metadata/environment.go
Line 137 in 61f4c6a
woodpecker/pipeline/frontend/metadata/environment.go
Line 29 in 61f4c6a
The environment variable returns a blank string because the regexp can't find an integer. Fix the reference using the pull request ID.
Test
The workflow reference link successfully redirects the user to the PR.