Correctly prefer datasource env var over file content

[6543]

close #3404

fixes #3389

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (364d708) 36.36% compared to head (4d37a15) 36.35%.

Files	Patch %	Lines
cmd/server/setup.go	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
- Coverage   36.36%   36.35%   -0.02%     
==========================================
  Files         228      228              
  Lines       15401    15407       +6     
==========================================
  Hits         5601     5601              
- Misses       9397     9403       +6     
  Partials      403      403              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[smainz]

That was option 5 :-), which I did not want to propose in #3404, due to consistency reasons. Now there are two different precendence rules for environment vars in place.

You still need to fix the documentation here:

woodpecker/docs/docs/30-administration/10-server-config.md

Line 72 in 364d708

Alternatively use docker-secrets. As it may be difficult to use docker secrets for environment variables woodpecker allows to read sensible data from files by providing a `*_FILE` option of all sensible configuration variables. Woodpecker will try to read the value directly from this file. Keep in mind that when the original environment variable gets specified at the same time it will override the value read from the file.

This is true for all but DATABASE_DATASOURCE_FILE

My referred solution was to stay with the preference rules stated above but use the least precedence way of setting the datasource in the docker image.

Anyway, thanks for taking the issue seriously.

[6543]

The cli lib we use is working on a v3 ... i have a look if there it is posible to specify the prio. If not atm you can suggest that :)

[smainz]

If you use a file for overriding the default value instead of setting the env var directly, it is the least precedence way.

So the only problem is how we set up the Dockerfile. This makes a setting, which is meant to be overridden a de facto hard coded value thus eliminating the flexibility urfave/cli provides.

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-3419.surge.sh