-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure config extensions for repos #3349
base: main
Are you sure you want to change the base?
Conversation
server/model/repo.go
Outdated
SecretExtensionEndpoint string `json:"secret_extension_endpoint" xorm:"varchar(500) 'secret_extension_endpoint'"` | ||
ConfigExtensionEndpoint string `json:"config_extension_endpoint" xorm:"varchar(500) 'config_extension_endpoint'"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are sent to all requests, including unauthorized.
Since you should use signing anyways that should be fine, but I just want to make sure this is expected?
} | ||
|
||
var blockedError error | ||
if blockList.MatchHostOrIP(host, tcpAddr.IP) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the blocklist used somewhere?
web/src/assets/locales/en.json
Outdated
"extensions": "Extensions", | ||
"extensions_description": "Extensions are HTTP services that can be called by Woodpecker instead of using the builtin ones.", | ||
"secrets_extension_endpoint": "Secrets extension endpoint", | ||
"secrets_extension_alpha_state": "The secret extension is in alpha state and might change in the future.", | ||
"extension_endpoint_placeholder": "e.g. https://my-extension-endpint.tld/api", | ||
"config_extension_endpoint": "Config extension endpoint", | ||
"extensions_signatures_public_key": "Public key for signatures", | ||
"extensions_signatures_public_key_description": "This public key should be used by your extensions to verify webhook calls from Woodpecker.", | ||
"extensions_configuration_saved": "Extensions configuration saved" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put them into their own object?
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
closes #783
Allow users to set / use service extensions (config) on a per repo basis. Those extensions are little external webservice which can implement a set of endpoints to replace woodpeckers internal functionality like:
TODO