Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that repo is disabled #2340

Merged
merged 7 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/api/badge.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ func GetBadge(c *gin.Context) {
repo, err = _store.GetRepo(repoID)
}

if err != nil || !repo.IsActive {
if err == nil || errors.Is(err, types.RecordNotExist) {
if err != nil {
if errors.Is(err, types.RecordNotExist) {
c.AbortWithStatus(http.StatusNotFound)
return
}
Expand Down
25 changes: 16 additions & 9 deletions server/api/user.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (

"github.com/gin-gonic/gin"
"github.com/gorilla/securecookie"

"github.com/woodpecker-ci/woodpecker/server"
"github.com/woodpecker-ci/woodpecker/server/model"
"github.com/woodpecker-ci/woodpecker/server/router/middleware/session"
Expand Down Expand Up @@ -90,15 +91,15 @@ func GetRepos(c *gin.Context) {
user := session.User(c)
all, _ := strconv.ParseBool(c.Query("all"))

activeRepos, err := _store.RepoList(user, true, true)
if err != nil {
c.String(http.StatusInternalServerError, "Error fetching repository list. %s", err)
return
}

if all {
dbRepos, err := _store.RepoList(user, true, false)
if err != nil {
c.String(http.StatusInternalServerError, "Error fetching repository list. %s", err)
return
}

active := map[model.ForgeRemoteID]*model.Repo{}
for _, r := range activeRepos {
for _, r := range dbRepos {
active[r.ForgeRemoteID] = r
}

Expand All @@ -111,10 +112,10 @@ func GetRepos(c *gin.Context) {
var repos []*model.Repo
for _, r := range _repos {
if r.Perm.Push {
if active[r.ForgeRemoteID] != nil && active[r.ForgeRemoteID].IsActive {
if active[r.ForgeRemoteID] != nil {
existingRepo := active[r.ForgeRemoteID]
existingRepo.Update(r)
existingRepo.IsActive = true
existingRepo.IsActive = active[r.ForgeRemoteID].IsActive
repos = append(repos, existingRepo)
} else {
repos = append(repos, r)
Expand All @@ -126,6 +127,12 @@ func GetRepos(c *gin.Context) {
return
}

activeRepos, err := _store.RepoList(user, true, true)
if err != nil {
c.String(http.StatusInternalServerError, "Error fetching repository list. %s", err)
return
}

c.JSON(http.StatusOK, activeRepos)
}

Expand Down
1 change: 1 addition & 0 deletions web/src/assets/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"reload": "Reload repositories",
"enable": "Enable",
"enabled": "Already enabled",
"disabled": "Disabled",
"success": "Repository enabled",
"list_reloaded": "Repository list reloaded"
},
Expand Down
16 changes: 9 additions & 7 deletions web/src/views/RepoAdd.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@
>
<span class="text-wp-text-100">{{ repo.full_name }}</span>
<span v-if="repo.active" class="ml-auto text-wp-text-alt-100">{{ $t('repo.enable.enabled') }}</span>
<Button
v-if="!repo.active"
class="ml-auto"
:text="$t('repo.enable.enable')"
:is-loading="isActivatingRepo && repoToActivate?.forge_remote_id === repo.forge_remote_id"
@click="activateRepo(repo)"
/>
<div v-else class="ml-auto flex items-center">
<Badge v-if="repo.id" class="<md:hidden mr-2" :label="$t('repo.enable.disabled')" />
<Button
:text="$t('repo.enable.enable')"
:is-loading="isActivatingRepo && repoToActivate?.forge_remote_id === repo.forge_remote_id"
@click="activateRepo(repo)"
/>
</div>
</ListItem>
</div>
</Scaffold>
Expand All @@ -30,6 +31,7 @@ import { onMounted, ref } from 'vue';
import { useI18n } from 'vue-i18n';
import { useRouter } from 'vue-router';

import Badge from '~/components/atomic/Badge.vue';
import Button from '~/components/atomic/Button.vue';
import ListItem from '~/components/atomic/ListItem.vue';
import Scaffold from '~/components/layout/scaffold/Scaffold.vue';
Expand Down