Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use browser-native tooltips #2189

Merged
merged 7 commits into from
Aug 20, 2023
Merged

Use browser-native tooltips #2189

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5c831da
Use browser-native tooltips
qwerty287 Aug 10, 2023
2b733e6
Merge branch 'main' into rm-floating
qwerty287 Aug 10, 2023
55c841e
Merge branch 'main' into rm-floating
qwerty287 Aug 11, 2023
bb5c3e1
Remove locale
qwerty287 Aug 11, 2023
71461fa
Merge branch 'main' into rm-floating
qwerty287 Aug 12, 2023
8371ce7
Merge branch 'main' into rm-floating
6543 Aug 19, 2023
10127f9
Merge branch 'main' into rm-floating
6543 Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"@vueuse/core": "^9.13.0",
"ansi_up": "^5.2.1",
"dayjs": "^1.11.9",
"floating-vue": "^2.0.0-beta.24",
"fuse.js": "^6.6.2",
"humanize-duration": "^3.28.0",
"javascript-time-ago": "^2.5.9",
Expand Down
35 changes: 0 additions & 35 deletions web/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 2 additions & 8 deletions web/src/components/pipeline-feed/PipelineFeedItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,9 @@
<span class="underline">{{ repo?.owner }} / {{ repo?.name }}</span>
<span class="whitespace-nowrap overflow-hidden overflow-ellipsis">{{ message }}</span>
<div class="flex flex-col mt-2">
<div class="flex space-x-2 items-center">
<div class="flex space-x-2 items-center" :title="created">
6543 marked this conversation as resolved.
Show resolved Hide resolved
<Icon name="since" />
<Tooltip>
<span>{{ since }}</span>
<template #popper
><span class="font-bold">{{ $t('repo.pipeline.created') }}</span> {{ created }}</template
>
</Tooltip>
<span>{{ since }}</span>
</div>
<div class="flex space-x-2 items-center">
<Icon name="duration" />
Expand All @@ -24,7 +19,6 @@
</template>

<script lang="ts" setup>
import { Tooltip } from 'floating-vue';
import { computed, toRef } from 'vue';

import Icon from '~/components/atomic/Icon.vue';
Expand Down
10 changes: 2 additions & 8 deletions web/src/components/repo/pipeline/PipelineItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,16 @@
<span class="truncate">{{ duration }}</span>
</div>

<div class="flex space-x-2 items-center min-w-0">
<div class="flex space-x-2 items-center min-w-0" :title="created">
<Icon name="since" />
<Tooltip>
<span>{{ since }}</span>
<template #popper>
<span class="font-bold">{{ $t('repo.pipeline.created') }}</span> {{ created }}
</template>
</Tooltip>
<span>{{ since }}</span>
</div>
</div>
</div>
</ListItem>
</template>

<script lang="ts" setup>
import { Tooltip } from 'floating-vue';
import { toRef } from 'vue';

import Icon from '~/components/atomic/Icon.vue';
Expand Down
1 change: 0 additions & 1 deletion web/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import 'windi.css';
import 'floating-vue/dist/style.css'; // eslint-disable-line no-restricted-imports
import '~/compositions/useFavicon';
import '~/style.css';

Expand Down
10 changes: 2 additions & 8 deletions web/src/views/repo/pipeline/PipelineWrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,9 @@

<template #tabActions>
<div class="flex justify-between gap-x-4 text-wp-text-100 flex-shrink-0 pb-2 md:p-0 mx-auto md:mr-0">
<div class="flex space-x-1 items-center flex-shrink-0">
<div class="flex space-x-1 items-center flex-shrink-0" :title="created">
<Icon name="since" />
<Tooltip>
<span>{{ since }}</span>
<template #popper
><span class="font-bold">{{ $t('repo.pipeline.created') }}</span> {{ created }}</template
qwerty287 marked this conversation as resolved.
Show resolved Hide resolved
>
</Tooltip>
<span>{{ since }}</span>
</div>
<div class="flex space-x-1 items-center flex-shrink-0">
<Icon name="duration" />
Expand All @@ -76,7 +71,6 @@
</template>

<script lang="ts" setup>
import { Tooltip } from 'floating-vue';
import { computed, inject, onBeforeUnmount, onMounted, provide, Ref, ref, toRef, watch } from 'vue';
import { useI18n } from 'vue-i18n';
import { useRoute, useRouter } from 'vue-router';
Expand Down